Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove obvious occurrences of legacy content repository class references #5428

Draft
wants to merge 1 commit into
base: 9.0
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Neos.Neos/Classes/Domain/Model/Site.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
use Doctrine\ORM\Mapping as ORM;
use Neos\Flow\Annotations as Flow;
use Neos\Media\Domain\Model\AssetCollection;
use Neos\Neos\Domain\Service\SiteNodeUtility;
use Neos\Utility\Arrays;

/**
Expand Down Expand Up @@ -158,8 +159,7 @@ public function getName()
/**
* Returns the node name of this site
*
* If you need to fetch the root node for this site, use the content
* context, do not use the NodeDataRepository!
* If you need to fetch the root node for this site, use {@see SiteNodeUtility::findSiteNodeBySite()}
*
* @return SiteNodeName The node name
* @api
Expand Down
2 changes: 1 addition & 1 deletion Neos.Neos/Classes/ViewHelpers/Link/NodeViewHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public function initializeArguments()
$this->registerArgument(
'baseNodeName',
'string',
'The name of the base node inside the Fusion context to use for the ContentContext'
'The name of the base node inside the Fusion context to use for the subgraph'
. ' or resolving relative paths',
false,
'documentNode'
Expand Down
2 changes: 1 addition & 1 deletion Neos.Neos/Classes/ViewHelpers/Uri/NodeViewHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public function initializeArguments()
$this->registerArgument(
'baseNodeName',
'string',
'The name of the base node inside the Fusion context to use for the ContentContext'
'The name of the base node inside the Fusion context to use for the subgraph'
. ' or resolving relative paths',
false,
'documentNode'
Expand Down
3 changes: 0 additions & 3 deletions Neos.Neos/Configuration/Settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -496,9 +496,6 @@ Neos:
fusionPathPatterns: ['resource://Neos.Neos/Private/Fusion/Error/Root.fusion']
enableContentCache: false
templatePathAndFilename: ~
debugger:
ignoredClasses:
Neos\\Neos\\Domain\\Service\\ContentContextFactory: true

package:
packagesPathByType:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,12 @@ A data source is a PHP class implementing ``Neos\Neos\Service\DataSource\DataSou

<?php

/*
* This script belongs to the package "Vendor.Site".
*/

declare(strict_types=1);

namespace Vendor\Site\Application\Neos\DataSource;

use Neos\Neos\Service\DataSource\AbstractDataSource;
use Neos\ContentRepository\Domain\Model\NodeInterface;
use Neos\ContentRepository\Core\Projection\ContentGraph\Node;

final class ColumnViewDataSource extends AbstractDataSource
{
Expand All @@ -38,11 +34,15 @@ A data source is a PHP class implementing ``Neos\Neos\Service\DataSource\DataSou
static protected $identifier = 'vendor-site-column-view';

/**
* Get data
*
* {@inheritdoc}
*/
public function getData(NodeInterface $node = NULL, array $arguments = [])
* Get data
*
* The return value must be JSON serializable data structure.
*
* @param Node $node The node that is currently edited (optional)
* @param array<mixed> $arguments Additional arguments (key / value)
* @return mixed JSON serializable data
*/
public function getData(Node $node = null, array $arguments = [])
{
return [
'data' => [
Expand Down Expand Up @@ -134,30 +134,30 @@ A data source is a PHP class implementing ``Neos\Neos\Service\DataSource\DataSou

<?php

/*
* This script belongs to the package "Vendor.Site".
*/

declare(strict_types=1);

namespace Vendor\Site\Application\Neos\DataSource;

use Neos\Neos\Service\DataSource\AbstractDataSource;
use Neos\ContentRepository\Domain\Model\NodeInterface;
use Neos\ContentRepository\Core\Projection\ContentGraph\Node;

final class TableViewDataSource extends AbstractDataSource
{
/**
* @var string
*/
* @var string
*/
static protected $identifier = 'vendor-site-table-view';

/**
* Get data
*
* {@inheritdoc}
*/
public function getData(NodeInterface $node = NULL, array $arguments = [])
* Get data
*
* The return value must be JSON serializable data structure.
*
* @param Node $node The node that is currently edited (optional)
* @param array<mixed> $arguments Additional arguments (key / value)
* @return mixed JSON serializable data
*/
public function getData(Node $node = null, array $arguments = [])
{
return [
'data' => [
Expand Down Expand Up @@ -262,20 +262,24 @@ A data source is a PHP class implementing ``Neos\Neos\Service\DataSource\DataSou
namespace Vendor\Site\Application\Neos\DataSource;

use Neos\Neos\Service\DataSource\AbstractDataSource;
use Neos\ContentRepository\Domain\Model\NodeInterface;
use Neos\ContentRepository\Core\Projection\ContentGraph\Node;

final class TimeSeriesViewDataSource extends AbstractDataSource
{
/**
* @var string
*/
* @var string
*/
static protected $identifier = 'vendor-site-time-series-view';

/**
* Get data
*
* {@inheritdoc}
*/
* Get data
*
* The return value must be JSON serializable data structure.
*
* @param Node $node The node that is currently edited (optional)
* @param array<mixed> $arguments Additional arguments (key / value)
* @return mixed JSON serializable data
*/
public function getData(NodeInterface $node = NULL, array $arguments = [])
{
return [
Expand Down
Loading