FEATURE: Make adjustments for missing tethered nodes recursive #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… duplicate events
…m:nezaniel/neos-development-collection into recursiveTetheredNodeStructureAdjustments
dlubitz
approved these changes
Feb 24, 2025
| @@ -184,4 +184,16 @@ public function migrateCheckpointsToSubscriptionsCommand(string $contentReposito | |||
| $eventMigrationService = $this->contentRepositoryRegistry->buildService($contentRepositoryId, $this->eventMigrationServiceFactory); | |||
| $eventMigrationService->migrateCheckpointsToSubscriptions($this->outputLine(...)); | |||
| } | |||
|
|
|||
| /** | |||
| * TODO Explain PLZ | |||
Comment on lines
+132
to
+144
| workspaceName: $contentGraph->getWorkspaceName(), | ||
| contentStreamId: $contentGraph->getContentStreamId(), | ||
| nodeAggregateId: $tetheredNodeAggregateId, | ||
| nodeTypeName: $tetheredNodeTypeDefinition->nodeTypeName, | ||
| originDimensionSpacePoint: $originDimensionSpacePoint, | ||
| succeedingSiblingsForCoverage: InterdimensionalSiblings::fromDimensionSpacePointSetWithoutSucceedingSiblings( | ||
| dimensionSpacePointSet: $parentNodeAggregateCoverageByOccupant | ||
| ), | ||
| parentNodeAggregateId: $parentNodeAggregateId, | ||
| nodeName: $tetheredNodeTypeDefinition->name, | ||
| initialPropertyValues: $defaultProperties, | ||
| nodeAggregateClassification: NodeAggregateClassification::CLASSIFICATION_TETHERED, | ||
| nodeReferences: SerializedNodeReferences::createEmpty(), |
There was a problem hiding this comment.
I wonder about the named parameter. I guess this is rather your preferred coding style than actually needed? Not sure if we already discussed this in past, but IMHO we should than.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the "add missing tethered nodes" adjustment work recursively
Upgrade instructions
none
Review instructions
This also contains a migration to remove duplicate node peer variation events, whose cause was fixed in #4969.
Not super clean as it is a separate concern; tested successfully in a live project
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions