TASK: Migrate fusion context.currentRenderingMode statements
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mficzel
force-pushed
the
90/migrateContextCurrentRenderingMode
branch
2 times, most recently
from
963f7a0 to
54fcabc
Compare
ahaeslich
requested changes
Oct 4, 2023
There was a problem hiding this comment.
The new rule should also be added to config/set/contentrepository-90.php. If think this commented lines could fit:
rector/config/set/contentrepository-90.php
Lines 290 to 292 in 24d8ffc
dlubitz
reviewed
Oct 4, 2023
Statements accessing `context.currentRenderingMode.edit|preview|name|title|fusionPath|options` on `node|site|documentNode` are migrated. Other uses of `context.currentRenderingMode` are marked with a comment. Resolves: #23
mficzel
force-pushed
the
90/migrateContextCurrentRenderingMode
branch
from
54fcabc to
e397f70
Compare
|
Offcourse @ahaeslich is right. Added the line and also adjusted the comments for the other renderingMode rectors. Any suggestions how to adjust this php wise. How can we migrate |
dlubitz
approved these changes
Oct 5, 2023
ahaeslich
approved these changes
Oct 6, 2023
|
@ahaeslich yes wanted to know wether we could migrate php code aswell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statements accessing using
(node|documentNode|site).context.currentRenderingMode.(edit|preview|name|title|fusionPath|options)are migrated. Other uses ofcontext.currentRenderingModeare marked with a comment.Resolves: #23