TASK Refactor ContentContext methods #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlubitz
changed the title
dlubitz
force-pushed
the
task/context-methods
branch
from
70bd4c5 to
236e661
Compare
dlubitz
force-pushed
the
task/context-methods
branch
from
de418d4 to
6425df9
Compare
dlubitz
changed the title
dlubitz
requested review from
skurfuerst,
bwaidelich,
mficzel,
ahaeslich,
mhsdesign and
nezaniel
dlubitz
commented
Nov 2, 2023
| @@ -275,23 +279,22 @@ | |||
| * ContentContext | |||
| */ | |||
| // ContentContext::getCurrentSite | |||
| // TODO: PHP | |||
| $methodCallToWarningComments[] = new MethodCallToWarningComment(LegacyContextStub::class, 'getCurrentSite', '!! ContentContext::getCurrentSite() is removed in Neos 9.0.'); | |||
There was a problem hiding this comment.
What can we suggest here as replacement?
dlubitz
commented
Nov 2, 2023
| // ContentContext::getCurrentDomain | ||
| // TODO: PHP | ||
| // TODO: Fusion | ||
| $methodCallToWarningComments[] = new MethodCallToWarningComment(LegacyContextStub::class, 'getCurrentDomain', '!! ContentContext::getCurrentDomain() is removed in Neos 9.0.'); |
There was a problem hiding this comment.
What can we suggest here as replacement?
dlubitz
commented
Nov 2, 2023
| // TODO: PHP | ||
| // TODO: Fusion | ||
| $methodCallToWarningComments[] = new MethodCallToWarningComment(LegacyContextStub::class, 'getCurrentDomain', '!! ContentContext::getCurrentDomain() is removed in Neos 9.0.'); | ||
| $fusionNodePropertyPathToWarningComments[] = new FusionNodePropertyPathToWarningComment('context.currentDomain', 'Line %LINE: !! node.context.currentDomain is removed in Neos 9.0.'); |
There was a problem hiding this comment.
What can we suggest here as replacement?
dlubitz
commented
Nov 2, 2023
dlubitz
commented
Nov 2, 2023
| // TODO: PHP | ||
| // TODO: Fusion | ||
| $methodCallToWarningComments[] = new MethodCallToWarningComment(LegacyContextStub::class, 'getCurrentSiteNode', '!! ContentContext::getCurrentSiteNode() is removed in Neos 9.0.'); | ||
| $fusionNodePropertyPathToWarningComments[] = new FusionNodePropertyPathToWarningComment('context.currentSiteNode', 'Line %LINE: !! node.context.currentSiteNode is removed in Neos 9.0.'); |
There was a problem hiding this comment.
What can we suggest here as replacement?
dlubitz
changed the title
# Conflicts: # config/set/contentrepository-90.php
ahaeslich
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rector replaces removed ContentContext calls in PHP and Fusion. For better detection of context objects all Node(Interface)s get replaced by
Neos\Rector\ContentRepository90\Legacy\NodeLegacyStub. TheNeos\Rector\ContentRepository90\Legacy\NodeLegacyStubget replaced at the end byNeos\ContentRepository\Core\Projection\ContentGraph\NodePHP
ContentContext::isInBackend=>$this->renderingModeService->findByCurrentUser()->isEditContentContext::isLive=>!$this->renderingModeService->findByCurrentUser()->isEdit && !$this->renderingModeService->findByCurrentUser()->isPreviewContentContext::getCurrentRenderingMode=>$this->renderingModeService->findByCurrentUser()ContentContext::getCurrentSiteNode=> Warning, no replacementContentContext::getCurrentDomain=> Warning, no replacementContentContext::getCurrentSite=> Warning, no replacementFusion
node.context.currentDomain=> Warning, no replacementcontext.currentSiteNode=> Warning, no replacementFixes #31