TASK: Remove "internal" node properties #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds rector migrations for common "underscore" internal property access on nodes. Related: neos/#4208
|
Mmm, these test failures seem unrelated? |
Sure are. I stumbled upon them with my PR and as I investigated the last successful run on |
|
Upon further investigation using Next step in this 🐰 hole: why can't we relax the requirement? |
dlubitz
reviewed
Mar 17, 2024
There was a problem hiding this comment.
@kitsunet Thanks for taking care. Could you please add the new cases to the existing tests?
E.g here for _depth:
https://github.com/neos/rector/blob/main/tests/ContentRepository90/Rules/FusionNodeDepthRector/Fixture/some_file.fusion.inc
dlubitz
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds rector migrations for common "underscore" internal property access on nodes.
Related: #neos-development-collection/4208