Skip to content

fix: outdated test test_compare_against_str #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hf-kklein
Copy link
Contributor

@hf-kklein hf-kklein commented May 4, 2025

I don't know if this is the actually expected behaviour but at least the test passes now. I'd strongly recommend running all tests in the CI/a PR always and not commiting or pushing directly to master to prevent broken tests on the default/main/master branch or accidentially releasing with broken/outdated tests.

there are other broken tests:

                      raise ValidationError(
                           f"{self.tag} Segment, pos. {index}: {e}"
                       )

E pydifact.exceptions.ValidationError: UNB Segment, pos. 3: Tag 0017 (Date) must be numeric and must have 6 digits. Current value: '07042029'

where the test setup is already errornous - no idea what is the new expected behaviour there.

If the failing Tests are intentional, you might use @pytest.skip("an explanation goes here") decorator for the test function

I don't know if this is the actually expected behaviour but at least the test passes now. I'd strongly recommend running all tests in the CI/a PR always and not commiting directly to master to prevent broken tests on the default/main/master branch or accidentially releasing with broken/outdated tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant