Skip to content

[Snyk] Upgrade electron from 33.2.0 to 34.1.1 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

nerdy-tech-com-gitub
Copy link
Owner

@nerdy-tech-com-gitub nerdy-tech-com-gitub commented Mar 6, 2025

snyk-top-banner

Snyk has created this PR to upgrade electron from 33.2.0 to 34.1.1.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


⚠️ Warning: This PR contains major version upgrade(s), and may be a breaking change.

  • The recommended version is 37 versions ahead of your current version.

  • The recommended version was released a month ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
medium severity Access Restriction Bypass
SNYK-JS-ELECTRON-8381013
115 No Known Exploit
critical severity Out-of-bounds Write
SNYK-JS-ELECTRON-8642944
115 No Known Exploit
high severity External Control of Assumed-Immutable Web Parameter
SNYK-JS-ELECTRON-8642946
115 No Known Exploit
high severity Out-of-bounds Read
SNYK-JS-ELECTRON-8642948
115 No Known Exploit
high severity Out-of-bounds Write
SNYK-JS-ELECTRON-8738830
115 No Known Exploit
high severity Out-of-bounds Write
SNYK-JS-ELECTRON-8738832
115 No Known Exploit
high severity Out-of-bounds Read
SNYK-JS-ELECTRON-8738836
115 No Known Exploit
medium severity Heap-based Buffer Overflow
SNYK-JS-ELECTRON-8738839
115 No Known Exploit
Release notes
Package name: electron
  • 34.1.1 - 2025-02-07

    Release Notes for v34.1.1

    Other Changes

    • Backported fix for 387258077,383070811. #45497
  • 34.1.0 - 2025-02-05

    Release Notes for v34.1.0

    Features

    • Added view.getVisible(). #45410 (Also in 35)
    • Added permission support for document.executeCommand("paste"). #45472 (Also in 33, 35)

    Fixes

    • Fixed a bug where the default path didn't always correctly fill the Name field in KDialogs on Linux. #45419 (Also in 35)
    • Fixed an issue where RTL tooltips could be incorrect when using WCO on Windows. #45426 (Also in 33, 35)
    • Fixed an issue where Windows Control Overlay didn't work with some window configurations. #45478
    • Fixed an issue where selection of multiple directories with the dialog module didn't work on Linux. #45395 (Also in 35)

    Other Changes

    • Added NSPrefersDisplaySafeAreaCompatibilityMode = false to Info.plist to remove "Scale to fit below built-in camera." from app options. #45469 (Also in 33, 35)
    • Updated Chromium to 132.0.6834.194. #45480
  • 34.0.2 - 2025-01-29
  • 34.0.1 - 2025-01-22
  • 34.0.0 - 2025-01-14
  • 34.0.0-beta.16 - 2025-01-09
  • 34.0.0-beta.15 - 2025-01-07
  • 34.0.0-beta.14 - 2024-12-23
  • 34.0.0-beta.13 - 2024-12-19
  • 34.0.0-beta.12 - 2024-12-16
  • 34.0.0-beta.11 - 2024-12-11
  • 34.0.0-beta.10 - 2024-12-09
  • 34.0.0-beta.9 - 2024-12-05
  • 34.0.0-beta.8 - 2024-12-02
  • 34.0.0-beta.7 - 2024-11-28
  • 34.0.0-beta.6 - 2024-11-25
  • 34.0.0-beta.5 - 2024-11-21
  • 34.0.0-beta.4 - 2024-11-18
  • 34.0.0-beta.3 - 2024-11-15
  • 34.0.0-beta.2 - 2024-11-14
  • 34.0.0-beta.1 - 2024-11-12
  • 34.0.0-alpha.9 - 2024-11-11
  • 34.0.0-alpha.8 - 2024-11-07
  • 34.0.0-alpha.7 - 2024-11-04
  • 34.0.0-alpha.6 - 2024-10-31
  • 34.0.0-alpha.5 - 2024-10-28
  • 34.0.0-alpha.4 - 2024-10-25
  • 34.0.0-alpha.3 - 2024-10-23
  • 34.0.0-alpha.2 - 2024-10-17
  • 34.0.0-alpha.1 - 2024-10-16
  • 33.4.2 - 2025-02-27
  • 33.4.1 - 2025-02-15
  • 33.4.0 - 2025-02-06

    Release Notes for v33.4.0

    Features

    • Added permission support for document.executeCommand("paste"). #45473 (Also in 34, 35)

    Fixes

    • Fixed a crash when calling shell.readShortcutLink caused by PKEY_AppUserModel_ToastActivatorCLSID sometimes being represented by a string uuid. #45349 (Also in 34)
    • Fixed an issue where RTL tooltips could be incorrect when using WCO on Windows. #45424 (Also in 34, 35)
    • Fixed crash in gin::wrappable::secondweakcallback. #45379 (Also in 34, 35)

    Other Changes

    • Added NSPrefersDisplaySafeAreaCompatibilityMode = false to Info.plist to remove "Scale to fit below built-in camera." from app options. #45470 (Also in 34, 35)
  • 33.3.2 - 2025-01-22
  • 33.3.1 - 2025-01-06
  • 33.3.0 - 2024-12-05
  • 33.2.1 - 2024-11-27
  • 33.2.0 - 2024-11-07
from electron GitHub release notes

Important

  • Warning: This PR contains a major version upgrade, and may be a breaking change.
  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Summary by Sourcery

Bug Fixes:

  • Fixes multiple security vulnerabilities including Access Restriction Bypass, Out-of-bounds Write/Read, and Heap-based Buffer Overflow.

Snyk has created this PR to upgrade electron from 33.2.0 to 34.1.1.

See this package in npm:
electron

See this project in Snyk:
https://app.snyk.io/org/nerds-github/project/7ac3a559-e245-43bc-aea8-6d68ed454985?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

sourcery-ai bot commented Mar 6, 2025

Reviewer's Guide by Sourcery

This pull request upgrades the electron dependency from version 33.2.0 to 34.1.1. This upgrade includes several security fixes and new features.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
The pull request upgrades the electron dependency to the latest version.
  • Updated electron from version 33.2.0 to 34.1.1.
apps/main/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants