Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding basic primatives #90

Closed
tancik opened this issue Aug 26, 2023 · 2 comments · Fixed by #132
Closed

Support adding basic primatives #90

tancik opened this issue Aug 26, 2023 · 2 comments · Fixed by #132
Labels
reasonable first issue Possibly good for newcomers

Comments

@tancik
Copy link
Collaborator

tancik commented Aug 26, 2023

We should make it easy to add basic primitives like cubes and spheres.

@brentyi
Copy link
Collaborator

brentyi commented Aug 28, 2023

It's pretty quick to generate these with trimesh and then send them over, like here:
https://github.com/nerfstudio-project/viser/blob/5bd1d2e7a60c64011dd51a8db8d240d52848b5d7/examples/12_click_meshes.py#L45C1-L64

Do you think we should write our own wrappers? Maybe just highlighting this in the documentation would be enough.

@tancik
Copy link
Collaborator Author

tancik commented Aug 28, 2023

I think wrappers could be nice. These are very common actions, requiring people to use trimesh requires knowing another library. Additionally, tab completing viser_server.add_ to see all the things you can add will probably be a pretty common user flow, having add_cube show up right there would be handy.

@brentyi brentyi added the reasonable first issue Possibly good for newcomers label Sep 19, 2023
@tancik tancik linked a pull request Nov 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reasonable first issue Possibly good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants