Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added box and icosphere primitives #132

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Added box and icosphere primitives #132

merged 5 commits into from
Nov 28, 2023

Conversation

pritzza
Copy link
Contributor

@pritzza pritzza commented Nov 21, 2023

Created wrappers for adding some of the different primitive shapes in trimesh library like boxes and icospheres.

Still need to add wrappers for remaining primitives.

@pritzza pritzza requested a review from brentyi November 21, 2023 22:25
@tancik tancik linked an issue Nov 28, 2023 that may be closed by this pull request
Support adding basic primatives #90
Closed
@brentyi brentyi enabled auto-merge (squash) November 28, 2023 02:12
brentyi
brentyi reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a pass with some minor changes, docstrings, types, etc!

The main functional difference is I switched away from wrapping add_glb(), and added a specific flat_shading flag to add_mesh_simple(). This helps us make the spheres smoother. 🙂

@brentyi brentyi merged commit 02519f0 into main Nov 28, 2023
12 checks passed
@brentyi brentyi deleted the jonathan/primitives branch November 28, 2023 02:25
yzslab pushed a commit to yzslab/viser that referenced this pull request Oct 20, 2024
@pritzza @brentyi
Added box and icosphere primitives (nerfstudio-project#132)
4fbf164 
* Added box and icosphere primitives

* Nits

---------

Co-authored-by: Jonathan <[email protected]>
Co-authored-by: Brent Yi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentyi brentyi brentyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support adding basic primatives
2 participants
@pritzza @brentyi