Support Climate Devices v1 #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for climate devices. - It works the same as the cover domain. - It waits 3 seconds after the latest change by the user before doing a service call (climate.set_temperature) This version only shows the thermostat, not the temperature.
nervetattoo
requested changes
Jan 30, 2020
| @@ -381,6 +383,45 @@ class BannerCard extends LitElement { | |||
| </div> | |||
| `; | |||
| } | |||
|
|
|||
| renderDomainClimate(options) { | |||
| let entity_id = options.entity.split(".")[1]; | |||
| }; | ||
| let onThermostatArrowClick = (diff) => { | ||
| clearTimeout(this._updateThermostateTemperatureTimeout); | ||
| options.attributes.temperature += diff; |
There was a problem hiding this comment.
Modifying the passed state object is not a good idea. A pure HA state object has a single source or truth, but when modifying it it gets confusing. I get that waiting for state changes to come back from HA takes too long for climate devices though. Perhaps keeping a this.stagedChanges = { [entityId]: { temperature: newTemperature } } or something similar could work. It would have to for example use a timestamp that is used in set hass (){} to clear the staged changes once a newer value comes from HA.
| role="button" | ||
| @click=${onThermostatArrowUpClick} | ||
| ></paper-icon-button> | ||
| <span class="${entity_id}_value">${thermostatTemperature.toFixed(1)}</span> |
There was a problem hiding this comment.
The value + the heading should be clickable to bring up the native more info dialog like it works for for example sensors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for climate devices.
This version only shows the thermostat, not the temperature.