Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funding tx management (CKB Only) #16

Closed
wants to merge 1 commit into from

Conversation

doitian
Copy link
Member

@doitian doitian commented Apr 29, 2024

The sepc256k1 private key must be saved as a file using the path "ckb_chain/key". The file must encode the private key as hex without the "0x" prefix.

Example config:

ckb_chain:
  # sighash_all
  funding_source_lock_script_code_hash: "0x9bd7e06f3ecf4be0f2fcd2188b23f1b9fcc88e5d4b65a8637b17723bbda3cce8"
  funding_source_lock_script_hash_type: "type"

  # funding lock
  funding_cell_lock_script_code_hash: "0x8090ce20be9976e2407511502acebf74ac1cfed10d7b35b7f33f56c9bd0daec6"
  funding_cell_lock_script_hash_type: "type"

services:
  - ckb_chain

@doitian doitian changed the base branch from main to channel-actor April 29, 2024 07:31
src/ckb_chain/config.rs Outdated Show resolved Hide resolved
src/ckb_chain/config.rs Outdated Show resolved Hide resolved
src/ckb_chain/config.rs Outdated Show resolved Hide resolved
src/ckb_chain/funding/funding_tx.rs Outdated Show resolved Hide resolved
src/ckb_chain/funding/funding_tx.rs Show resolved Hide resolved
@@ -0,0 +1,9 @@
mod actor;
Copy link
Collaborator

@contrun contrun May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality of the mod ckb_chain is indispensable for the ckb payment channel network. I think this mod would suit itself better as an sub module to ckb. How do you think of that? One benefit of using ckb_chain as a separate service is that in this case we can run a standalone daemon remotely that does nothing but signing funding transactions. I don't know if this is a real use case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinion on this. However, I think we'd better refactor it into a submodule later after the demo.

@doitian doitian force-pushed the funding-tx branch 2 times, most recently from a308104 to 47487ba Compare May 10, 2024 05:45
@doitian doitian changed the title Funding tx management Funding tx management (CKB Only) May 11, 2024
@doitian doitian marked this pull request as ready for review May 11, 2024 02:45
@doitian doitian force-pushed the funding-tx branch 2 times, most recently from 1ce97ce to d2e4c5e Compare May 11, 2024 02:49
@doitian doitian mentioned this pull request May 11, 2024
4 tasks
@contrun contrun closed this May 15, 2024
@doitian doitian deleted the funding-tx branch July 18, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants