-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update model documentation for iaf_psc_delta
model
#3086
Conversation
Co-authored-by: jasperalbers <[email protected]>
iaf_psc_delta
modeliaf_psc_delta
model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks quite good, see small comments inline.
But it made me also wonder about the units of i_syn, also in the other iaf_psc models. We need to take a look at that.
@ackurth I looked more closely at this (also for the alpha case) and the situation is as follows:
What do you think? |
Co-authored-by: Hans Ekkehard Plesser <[email protected]>
Co-authored-by: Hans Ekkehard Plesser <[email protected]>
I reformulated now trying to avoid the unit issue but to be very explicit regarding what is going on. |
This looks much better now. But I find the $\Delta \dot{V}{syn}$ a bit difficult to read. How about just $\dot{Delta}{syn}$? Concerning It would also be good to extend "where is the corresponding synaptic weight." to "where is the corresponding synaptic weight in mV." |
The units should be consistent now, please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ackurth Nice, thanks!
@ackurth There seems to be a line break missing, making the copyright-checker unhappy:
|
Co-authored-by: clinssen <[email protected]>
Co-authored-by: clinssen <[email protected]>
Co-authored-by: clinssen <[email protected]>
Co-authored-by: clinssen <[email protected]>
Co-authored-by: clinssen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this looks fine. Many thanks!
No description provided.