Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(caching.md): update redis example #2817

Closed

Conversation

SlinkyPotato
Copy link

replace legacy https://github.com/dabroek/node-cache-manager-redis-store with forked https://github.com/node-cache-manager/node-cache-manager-redis-yet

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

The original redis example of caching does not work with the latest version of cache manager. It looks like the package maintainers have abandoned the project node-cache-manager-redis-store.

Issue Number: N/A

What is the new behavior?

A new redis example is introduced that makes use of the forked repo node-manager-redis-yet.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@SlinkyPotato SlinkyPotato changed the title Update caching.md docs(caching.md): update redis example Aug 5, 2023
@Tony133
Copy link
Contributor

Tony133 commented Aug 6, 2023

There would already be a PR open here: #2703, waiting for it to be merged.

However, I hope it gets merged soon because it's the second PR being created related to this part of the redis-store, see also here: https://github.com/nestjs/docs.nestjs.com/pull /2778

@SlinkyPotato SlinkyPotato deleted the docs-cache-page-update branch August 10, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants