Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Redis Configuration in NestJS Documentation #2884

Closed
wants to merge 2 commits into from

Conversation

NG-Joseph
Copy link

@NG-Joseph NG-Joseph commented Oct 15, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

The current behavior is an outdated Redis implementation in the NestJS documentation due to changes made in the cache-manager-redis-store package.

Issue Number: N/A

What is the new behavior?

The new behavior includes updating the Redis configuration in the NestJS documentation to reflect the changes made in the cache-manager-redis-store package. The updated configuration includes specifying the socket object, setting the Redis database, and defining a ttl value for cache entries.

Does this PR introduce a breaking change?

  • Yes
  • [x ] No

Other information

N/A

@NG-Joseph NG-Joseph changed the title Update caching.md Update Redis Configuration in NestJS Documentation Oct 15, 2023
@NG-Joseph NG-Joseph marked this pull request as draft October 15, 2023 19:13
@Tony133
Copy link
Contributor

Tony133 commented Oct 15, 2023

There would already be a PR open here: #2703, waiting for it to be merged.

@NG-Joseph
Copy link
Author

Noted. Thanks!

@NG-Joseph NG-Joseph closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants