Skip to content

chore(common): Backport FileTypeValidator fallback support to v10.4.17 #15003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 10.4.17
Choose a base branch
from

Conversation

mag123c
Copy link
Contributor

@mag123c mag123c commented Apr 22, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

File validation fails when the buffer is too small or unidentifiable by magic number,
even if the mimetype is correct.

Related issue: #14977

What is the new behavior?

  • Adds a fallbackToMimetype option to FileTypeValidator
  • If magic number detection fails, and fallback is enabled, the validator uses the mimetype
  • Also improves buildErrorMessage() for clearer failure messages

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR backports the fix originally merged in #14995 into the 10.4.17 line.

This was originally reported in #14977. All tests have been verified on the v10 codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant