chore(common): Backport FileTypeValidator fallback support to v10.4.17 #15003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
File validation fails when the buffer is too small or unidentifiable by magic number,
even if the mimetype is correct.
Related issue: #14977
What is the new behavior?
fallbackToMimetype
option toFileTypeValidator
buildErrorMessage()
for clearer failure messagesDoes this PR introduce a breaking change?
Other information
This PR backports the fix originally merged in #14995 into the
10.4.17
line.This was originally reported in #14977. All tests have been verified on the v10 codebase.