Support frozen strings #75
Conversation
net-scp.gemspec
Outdated
| @@ -35,15 +35,15 @@ Gem::Specification.new do |spec| | |||
| if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then | |||
| spec.add_runtime_dependency(%q<net-ssh>, [">= 2.6.5", "< 8.0.0"]) | |||
| spec.add_development_dependency(%q<test-unit>, [">= 0"]) | |||
| spec.add_development_dependency(%q<mocha>, [">= 0"]) | |||
| spec.add_dependency(%q<mocha>, [">= 0", "<2.1"]) | |||
There was a problem hiding this comment.
why was it converted to non dev dependency?
|
Why should frozen-string-literals be enabled in the CI? I also think it is better to have |
To catch any other places that would fail if frozen strings were enabled. And to also catch regressions
I think this just outputs warnings. In CI we would want actual failures. Looks like the failures are due to net-ssh not yet supporting frozen strings |
|
This is not a good solution to fail all tests as long as Net::SCP didn't fix its frozen string literals, because no CI test will work and we will not be able to see if a PR is OK or not. Frozen string literals will only be default in Ruby 4.0, so we have no rush and out CI will fail against ruby-head as soon as it is make default there. I propose not to enable frozen string literals, and to modify Rakefile to warn about them: Rake::TestTask.new do |t|
t.ruby_opts = ['-W:deprecated']
t.libs = ["lib", "test"]
endThis way, we can see where there is work to do, and we still can use the CI to check against all ruby versions. |
No description provided.