Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting to change dashboard view for regular users #362

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Add setting to change dashboard view for regular users #362

merged 3 commits into from
Mar 27, 2024

Conversation

heisbrot
Copy link
Contributor

Setting to restrict dashboard view
CleanShot 2024-03-25 at 14 29 11

View for Regular Users if the setting is enabled
CleanShot 2024-03-25 at 14 28 14

View for Regular Users if the setting is disabled
CleanShot 2024-03-25 at 14 30 07

@heisbrot heisbrot requested a review from pascal-fischer March 25, 2024 13:31
pascal-fischer
pascal-fischer approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@pascal-fischer pascal-fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% sure about the wording 'regular users' but at the same time I do not have a good alternative. "Users with user role" would be the most precise but sounds odd when you read it

@braginini braginini merged commit 973ccef into main Mar 27, 2024
4 checks passed
@braginini braginini deleted the feature/limited-dashboard-view branch March 27, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascal-fischer pascal-fischer pascal-fischer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heisbrot @pascal-fischer @braginini