Fix typo and add log

netbirdio · Feb 2, 2025 · 5930330 · 5930330
1 parent b9029e0
commit 5930330
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/client/firewall/iptables/router_linux.go b/client/firewall/iptables/router_linux.go
@@ -586,7 +586,7 @@ func (r *router) updateState() {
 }
 
 func (r *router) AddDNATRule(rule firewall.ForwardRule) (firewall.Rule, error) {
-	if err := r.ipFwdState.ReleaseForwarding(); err != nil {
+	if err := r.ipFwdState.RequestForwarding(); err != nil {
 		return nil, err
 	}
 

diff --git a/client/firewall/nftables/router_linux.go b/client/firewall/nftables/router_linux.go
@@ -962,7 +962,7 @@ func (r *router) refreshRulesMap() error {
 }
 
 func (r *router) AddDNATRule(rule firewall.ForwardRule) (firewall.Rule, error) {
-	if err := r.ipFwdState.ReleaseForwarding(); err != nil {
+	if err := r.ipFwdState.RequestForwarding(); err != nil {
 		return nil, err
 	}
 

diff --git a/client/internal/routemanager/ipfwdstate/ipfwdstate.go b/client/internal/routemanager/ipfwdstate/ipfwdstate.go
@@ -2,6 +2,9 @@ package ipfwdstate
 
 import (
 	"fmt"
+
+	log "github.com/sirupsen/logrus"
+
 	"github.com/netbirdio/netbird/client/internal/routemanager/systemops"
 )
 
@@ -23,6 +26,7 @@ func (f *IPForwardingState) RequestForwarding() error {
 		return fmt.Errorf("failed to enable IP forwarding with sysctl: %w", err)
 	}
 	f.enabledCounter = 1
+	log.Info("IP forwarding enabled")
 
 	return nil
 }
@@ -43,5 +47,7 @@ func (f *IPForwardingState) ReleaseForwarding() error {
 	if err := systemops.DisableIPForwarding(); err != nil {
 		return fmt.Errorf("failed to disable IP forwarding with sysctl: %w", err)
 	}
+	log.Info("IP forwarding disabled")
+
 	return nil
 }