fix(networkmonitor): false engine restarts

[hurricanehrndz]

Describe your changes

Network monitor should only trigger engine restarts when route get actually changes. There are many other instances when unspecified address get added to the system without actually affecting the real default route.

** change depends on **
netbirdio/go-netroute#5

Issue ticket number and link

fixes #3352

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

[hurricanehrndz]

Please do not merge until go-netroute gets updated and merged.

[lixmal]

https://github.com/netbirdio/netbird/pull/3355/files#diff-0f6b5bd1fd7206f0c6c1450e86746586e21d8a9bf4eda7d356e65d096893ac98R61

With this change RTM_CHANGE could also make sense. Would you mind testing that with route change ...?

Can you also add some comments why we're doing this differently on bsd (multiple 0.0.0.0/0 etc)

[hurricanehrndz]

With the newest changes, this is the log when I pull out my usb-c wired connection

2025-02-20T12:23:52-07:00       info    client/internal/networkmonitor.checkChange      Network monitor: default route changed, v4GatewayChanged: true v4Gateway: "invalid IP", v6GatewayChanged: true, v6Gateway: "fe80::2d0:4cff:fe10:15d2%en0", IntfV4Changed: true, v4Intf: (*net.Interface)(nil),  v6IntfChanged: true, v6Intf: &net.Interface{Index:15, MTU:1500, Name:"en0", HardwareAddr:net.HardwareAddr{0x2e, 0xcf, 0x11, 0xd3, 0x8d, 0xc3}, Flags:0x33}
2025-02-20T12:23:52-07:00       info    client/internal.(*Engine).startNetworkMonitor.func1.1   Network monitor: detected network change, reset debounceTimer
2025-02-20T12:23:52-07:00       info    client/internal/networkmonitor.checkChange      Network monitor: failed to check next hop, assuming no network connection available: route not found
2025-02-20T12:23:52-07:00       info    client/internal/networkmonitor.checkChange      Network monitor: default route changed, v4GatewayChanged: true v4Gateway: "invalid IP", v6GatewayChanged: true, v6Gateway: "fe80::2d0:4cff:fe10:15d2%en0", IntfV4Changed: true, v4Intf: (*net.Interface)(nil),  v6IntfChanged: true, v6Intf: &net.Interface{Index:15, MTU:1500, Name:"en0", HardwareAddr:net.HardwareAddr{0x2e, 0xcf, 0x11, 0xd3, 0x8d, 0xc3}, Flags:0x33}
2025-02-20T12:23:52-07:00       info    client/internal.(*Engine).startNetworkMonitor.func1.1   Network monitor: detected network change, reset debounceTimer
2025-02-20T12:23:52-07:00       info    client/internal.(*Engine).startNetworkMonitor.func1.1   Network monitor: detected network change, reset debounceTimer
2025-02-20T12:23:52-07:00       info    client/internal/networkmonitor.checkChange      Network monitor: failed to check next hop, assuming no network connection available: route not found
2025-02-20T12:23:52-07:00       info    client/internal/networkmonitor.checkChange      Network monitor: default route changed, v4GatewayChanged: true v4Gateway: "invalid IP", v6GatewayChanged: true, v6Gateway: "fe80::2d0:4cff:fe10:15d2%en0", IntfV4Changed: true, v4Intf: (*net.Interface)(nil),  v6IntfChanged: true, v6Intf: &net.Interface{Index:15, MTU:1500, Name:"en0", HardwareAddr:net.HardwareAddr{0x2e, 0xcf, 0x11, 0xd3, 0x8d, 0xc3}, Flags:0x33}
2025-02-20T12:23:52-07:00       info    client/internal.(*Engine).startNetworkMonitor.func1.1   Network monitor: detected network change, reset debounceTimer
2025-02-20T12:23:52-07:00       info    client/internal.(*Engine).startNetworkMonitor.func1.1   Network monitor: detected network change, reset debounceTimer
2025-02-20T12:23:52-07:00       info    client/internal/networkmonitor.checkChange      Network monitor: default route changed, v4GatewayChanged: false v4Gateway: "172.28.250.1", v6GatewayChanged: true, v6Gateway: "fe80::2d0:4cff:fe10:15d2%en0", IntfV4Changed: true, v4Intf: &net.Interface{Index:15, MTU:1500, Name:"en0", HardwareAddr:net.HardwareAddr{0x2e, 0xcf, 0x11, 0xd3, 0x8d, 0xc3}, Flags:0x33},  v6IntfChanged: true, v6Intf: &net.Interface{Index:15, MTU:1500, Name:"en0", HardwareAddr:net.HardwareAddr{0x2e, 0xcf, 0x11, 0xd3, 0x8d, 0xc3}, Flags:0x33}
2025-02-20T12:23:52-07:00       info    client/internal/networkmonitor.checkChange      Network monitor: default route changed, v4GatewayChanged: false v4Gateway: "172.28.250.1", v6GatewayChanged: true, v6Gateway: "fe80::2d0:4cff:fe10:15d2%en0", IntfV4Changed: true, v4Intf: &net.Interface{Index:15, MTU:1500, Name:"en0", HardwareAddr:net.HardwareAddr{0x2e, 0xcf, 0x11, 0xd3, 0x8d, 0xc3}, Flags:0x33},  v6IntfChanged: true, v6Intf: &net.Interface{Index:15, MTU:1500, Name:"en0", HardwareAddr:net.HardwareAddr{0x2e, 0xcf, 0x11, 0xd3, 0x8d, 0xc3}, Flags:0x33}
2025-02-20T12:23:52-07:00       info    client/internal.(*Engine).startNetworkMonitor.func1.1   Network monitor: detected network change, reset debounceTimer
2025-02-20T12:23:52-07:00       info    client/internal.(*Engine).startNetworkMonitor.func1.1   Network monitor: detected network change, reset debounceTimer
2025-02-20T12:23:54-07:00       info    client/internal.(*Engine).startNetworkMonitor.func1.1.1 Network monitor: detected network change, restarting engine

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[hurricanehrndz]

Once the go-netroute PR is merge I can update the go.mod file