Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: seahorse: add redirect org.gnome.seahorse.Application #6673

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Mar 1, 2025

Apparently the .desktop file for seahorse is located in the following
path:

  • /usr/share/applications/org.gnome.seahorse.Application.desktop

Which ends in Application.desktop instead of seahorse.desktop,
leading to it not being automatically detected by firecfg.

So add a redirect profile and an entry in firecfg.config.

Fixes #6658.

Reported-by: @ginto37
Reported-by: @rusty-snake

@kmk3 kmk3 added the firecfg Anything related to firecfg and not firejail itself label Mar 1, 2025
@@ -698,6 +698,8 @@ opera
opera-beta
opera-developer
orage
#org.gnome.gedit # text editor (see #6002)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one shouldn't be necessary.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one shouldn't be necessary.

Removed.

@@ -698,6 +698,8 @@ opera
opera-beta
opera-developer
orage
#org.gnome.gedit # text editor (see #6002)
org.gnome.seahorse.Application
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work w/o redirect profile?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work w/o redirect profile?

Added.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other redirects for this bug use just the lastname approach: https://github.com/netblue30/firejail/blob/master/etc/profile-m-z/Maps.profile

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other redirects for this bug use just the lastname approach:
https://github.com/netblue30/firejail/blob/master/etc/profile-m-z/Maps.profile

firecfg recognizes the redirect profile with the following PR:

@kmk3 kmk3 marked this pull request as draft March 1, 2025 19:50
Apparently the .desktop file for `seahorse` is located in the following
path:

* /usr/share/applications/org.gnome.seahorse.Application.desktop

Which ends in `Application.desktop` instead of `seahorse.desktop`,
leading to it not being automatically detected by firecfg.

So add a redirect profile and an entry in firecfg.config.

Fixes netblue30#6658.

Reported-by: @ginto37
Reported-by: @rusty-snake
@kmk3 kmk3 force-pushed the firecfg-add-gedit-seahorse branch from 0282488 to 884d12c Compare March 1, 2025 20:06
@kmk3 kmk3 changed the title profiles: firecfg: add gedit/seahorse .desktop filenames profiles: seahorse: add redirect org.gnome.seahorse.Application Mar 1, 2025
@kmk3 kmk3 marked this pull request as ready for review March 1, 2025 20:07
@kmk3 kmk3 marked this pull request as draft March 1, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firecfg Anything related to firecfg and not firejail itself
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

firecfg: seahorse is not sandboxed (.desktop file)
2 participants