Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: IPv6-only support => Update docker/nginx-unit.json #1384

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MikuuW
Copy link

@MikuuW MikuuW commented Jan 28, 2025

Related Issue: N/A

New Behavior

We have noticed that since the release of Netbox v4.2.0. Our deployments stopped working in a pure IPv6 environment. After some troubleshooting we've found this PR where the nginx interface bindings have been changed. After overwriting docker/nginx-unit.json, our netbox was up and running again.

Contrast to Current Behavior

Bind IPv6 interfaces too

Discussion: Benefits and Drawbacks

Something like this would be a much nicer solution.

  "listeners": {
        "*:8080": {
          "pass": "routes/main",
          "forwarded": {
            "client_ip": "X-Forwarded-For",
            "protocol": "X-Forwarded-Proto",
            "source": [
              "10.0.0.0/8",
              "172.16.0.0/12",
              "192.168.0.0/16",
              "fc00::/7",
              "fe80::/10"
            ]
          }
        },
        "*:8081": {
          "pass": "routes/status",
          "forwarded": {
            "client_ip": "X-Forwarded-For",
            "protocol": "X-Forwarded-Proto",
            "source": [
              "10.0.0.0/8",
              "172.16.0.0/12",
              "192.168.0.0/16",
              "fc00::/7",
              "fe80::/10"
            ]
          }
        }
      }

But did not get it to work with the wildcard (but were not nginx experts).
Not explicitly tested in IPv4 environments.

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@MikuuW MikuuW marked this pull request as ready for review January 28, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants