Allow overriding image registry and Helm chart sources in NetBox deploy script #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
April 28, 2025 13:36
…ry instead of public repositories for binaries and helm charts
added 2 commits
May 5, 2025 11:34
…PACE passed as an argument
…PACE passed as an argument
added 6 commits
May 5, 2025 11:43
…is is set, otherwise, don't pass the flag and use the default one from the chart
…if this is set, otherwise, don't pass the flag and use the default one from the chart
pablogarciamiranda
changed the base branch from
feature/deploy-netbox-vcluster
to
main
# Conflicts: # kind/deploy-netbox.sh
bruelea
requested changes
May 6, 2025
| SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" | ||
|
|
||
| # Allow override via environment variable, otherwise fallback to default | ||
| NETBOX_HELM_CHART="${NETBOX_HELM_CHART:-https://github.com/netbox-community/netbox-chart/releases/download/netbox-5.0.0-beta.169/netbox-5.0.0-beta.169.tgz}" |
There was a problem hiding this comment.
Suggested change
| NETBOX_HELM_CHART="${NETBOX_HELM_CHART:-https://github.com/netbox-community/netbox-chart/releases/download/netbox-5.0.0-beta.169/netbox-5.0.0-beta.169.tgz}" | |
| NETBOX_HELM_CHART="${NETBOX_HELM_REPO:-https://github.com/}netbox-community/netbox-chart/releases/download/netbox-5.0.0-beta.169/netbox-5.0.0-beta.169.tgz" |
like this the version does not need to be updated manually in the environment variable but it's managed by the script.
| # Build optional set flag if registry is not defined | ||
| REGISTRY_ARG="" | ||
| if [ -n "$NETBOX_IMAGE_REGISTRY" ]; then | ||
| REGISTRY_ARG="--set image.registry=$NETBOX_IMAGE_REGISTRY" |
There was a problem hiding this comment.
Suggested change
| REGISTRY_ARG="--set image.registry=$NETBOX_IMAGE_REGISTRY" | |
| REGISTRY_ARG="--set global.imageRegistry=$NETBOX_IMAGE_REGISTRY --set global.security.allowInsecureImages=true" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
deploy-netbox.shscript to make it agnostic of any specific image repository or Artifactory instance.By exporting the following variables, users can override default URLs and images to point to their repositories: