write only CHART if obsolete (#1370)

netdata · Oct 13, 2023 · 1cfccdc · 1cfccdc
1 parent 11e0298
commit 1cfccdc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/agent/module/job.go b/agent/module/job.go
@@ -435,6 +435,11 @@ func (j *Job) createChart(chart *Chart) {
 		j.moduleName,
 	)
 
+	if chart.Obsolete {
+		_ = j.api.EMPTYLINE()
+		return
+	}
+
 	seen := make(map[string]bool)
 	for _, l := range chart.Labels {
 		if l.Key != "" {

diff --git a/agent/netdataapi/api.go b/agent/netdataapi/api.go
@@ -21,7 +21,7 @@ const quotes = "' '"
 
 var (
 	end          = []byte("END\n\n")
-	clabelCommit = []byte("CLABEL_COMMIT\n\n")
+	clabelCommit = []byte("CLABEL_COMMIT\n")
 	newLine      = []byte("\n")
 )
 

diff --git a/agent/netdataapi/api_test.go b/agent/netdataapi/api_test.go
@@ -160,7 +160,7 @@ func TestAPI_CLABELCOMMIT(t *testing.T) {
 
 	assert.Equal(
 		t,
-		"CLABEL_COMMIT\n\n",
+		"CLABEL_COMMIT\n",
 		buf.String(),
 	)
 }