Make everything private and final

netgen · Aug 9, 2019 · 3fe9425 · 3fe9425
1 parent 6e91ff0
commit 3fe9425
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 14 deletions.
diff --git a/Core/FieldType/ContentTypeList/Type.php b/Core/FieldType/ContentTypeList/Type.php
@@ -10,7 +10,7 @@
 use eZ\Publish\Core\FieldType\Value as BaseValue;
 use eZ\Publish\SPI\FieldType\Value as SPIValue;
 
-class Type extends FieldType
+final class Type extends FieldType
 {
     public function getFieldTypeIdentifier(): string
     {

diff --git a/Core/FieldType/ContentTypeList/Value.php b/Core/FieldType/ContentTypeList/Value.php
@@ -6,7 +6,7 @@
 
 use eZ\Publish\Core\FieldType\Value as BaseValue;
 
-class Value extends BaseValue
+final class Value extends BaseValue
 {
     /**
      * The list of content type identifiers.

diff --git a/Core/Persistence/Legacy/Content/FieldValue/Converter/ContentTypeListConverter.php b/Core/Persistence/Legacy/Content/FieldValue/Converter/ContentTypeListConverter.php
@@ -10,7 +10,7 @@
 use eZ\Publish\SPI\Persistence\Content\FieldValue;
 use eZ\Publish\SPI\Persistence\Content\Type\FieldDefinition;
 
-class ContentTypeListConverter implements Converter
+final class ContentTypeListConverter implements Converter
 {
     public function toStorageValue(FieldValue $value, StorageFieldValue $storageFieldValue): void
     {

diff --git a/DependencyInjection/NetgenContentTypeListExtension.php b/DependencyInjection/NetgenContentTypeListExtension.php
@@ -12,7 +12,7 @@
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 use Symfony\Component\Yaml\Yaml;
 
-class NetgenContentTypeListExtension extends Extension implements PrependExtensionInterface
+final class NetgenContentTypeListExtension extends Extension implements PrependExtensionInterface
 {
     public function load(array $configs, ContainerBuilder $container): void
     {

diff --git a/NetgenContentTypeListBundle.php b/NetgenContentTypeListBundle.php
@@ -6,6 +6,6 @@
 
 use Symfony\Component\HttpKernel\Bundle\Bundle;
 
-class NetgenContentTypeListBundle extends Bundle
+final class NetgenContentTypeListBundle extends Bundle
 {
 }
diff --git a/Tests/Core/FieldType/ContentTypeList/TypeTest.php b/Tests/Core/FieldType/ContentTypeList/TypeTest.php
@@ -11,27 +11,27 @@
 use Netgen\Bundle\ContentTypeListBundle\Core\FieldType\ContentTypeList\Value;
 use PHPUnit\Framework\TestCase;
 
-class TypeTest extends TestCase
+final class TypeTest extends TestCase
 {
     /**
      * @var Type
      */
-    protected $type;
+    private $type;
 
     /**
      * @var array
      */
-    protected $identifiers = ['identifier0', 'identifier1'];
+    private $identifiers = ['identifier0', 'identifier1'];
 
     /**
      * @var Value
      */
-    protected $value;
+    private $value;
 
     /**
      * @var Value
      */
-    protected $emptyValue;
+    private $emptyValue;
 
     protected function setUp(): void
     {

diff --git a/Tests/Core/FieldType/ContentTypeList/ValueTest.php b/Tests/Core/FieldType/ContentTypeList/ValueTest.php
@@ -8,12 +8,12 @@
 use Netgen\Bundle\ContentTypeListBundle\Core\FieldType\ContentTypeList\Value;
 use PHPUnit\Framework\TestCase;
 
-class ValueTest extends TestCase
+final class ValueTest extends TestCase
 {
     /**
      * @var Value
      */
-    protected $value;
+    private $value;
 
     protected function setUp(): void
     {

diff --git a/Tests/Core/Persistence/Legacy/Content/FieldValue/Converter/ContentTypeListConverterTest.php b/Tests/Core/Persistence/Legacy/Content/FieldValue/Converter/ContentTypeListConverterTest.php
@@ -12,12 +12,12 @@
 use Netgen\Bundle\ContentTypeListBundle\Core\Persistence\Legacy\Content\FieldValue\Converter\ContentTypeListConverter;
 use PHPUnit\Framework\TestCase;
 
-class ContentTypeListConverterTest extends TestCase
+final class ContentTypeListConverterTest extends TestCase
 {
     /**
      * @var ContentTypeListConverter
      */
-    protected $converter;
+    private $converter;
 
     protected function setUp(): void
     {