CED-1124 NGSTACK-831 edit infocollection #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getLegacyValue method
ludwig031
force-pushed
the
CED-1124-edit-infocollection
branch
from
ef6f4b3 to
39638ea
Compare
|
Rebased branch to 3.x to get new changes |
pspanja
reviewed
Feb 20, 2024
pspanja
reviewed
Feb 20, 2024
pspanja
reviewed
Feb 20, 2024
pspanja
reviewed
Feb 20, 2024
pspanja
reviewed
Feb 21, 2024
lib/Core/Persistence/FieldHandler/Custom/CountryFieldHandler.php
Outdated
Show resolved
Hide resolved
pspanja
reviewed
Feb 21, 2024
pspanja
reviewed
Feb 21, 2024
pspanja
reviewed
Feb 21, 2024
pspanja
reviewed
Mar 20, 2024
bundle/Form/DataWrapper.php
Outdated
| * | ||
| * @var mixed | ||
| */ | ||
| public $payload; |
There was a problem hiding this comment.
Missing type hint (below as well).
pspanja
reviewed
Mar 20, 2024
bundle/Form/DataWrapper.php
Outdated
| public $definition; | ||
|
|
||
| /** | ||
| * The target struct that applies to. E.g. Content, User, Section object and so on. |
There was a problem hiding this comment.
Adapt descriptions for info collection context.
pspanja
reviewed
Mar 20, 2024
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Netgen\Bundle\InformationCollectionBundle\Form\Type; |
There was a problem hiding this comment.
Since we have this namespace how, move other form types here.
pspanja
reviewed
Mar 20, 2024
| netgen_information_collection.form.fieldtype_handler.ezimage: | ||
| class: Netgen\Bundle\InformationCollectionBundle\Form\FieldTypeHandler\Image | ||
| tags: | ||
| - { name: netgen.ibexa_forms.form.fieldtype_handler, alias: ezimage } |
There was a problem hiding this comment.
Adapt tag name for this bundle.
pspanja
reviewed
Mar 20, 2024
| * @throws \OutOfBoundsException | ||
| * @throws \RuntimeException When type is not a FieldTypeHandlerInterface instance nor a callable factory | ||
| */ | ||
| public function get(string $identifier): FieldTypeHandlerInterface|\Netgen\Bundle\IbexaFormsBundle\Form\FieldTypeHandlerInterface |
There was a problem hiding this comment.
Second return type hint was for Birthday field type? We should copy it's handler here once the tag names are updated, so the handlers are not in conflict.
pspanja
reviewed
Mar 20, 2024
| /** | ||
| * Register a $service for FieldType $identifier. | ||
| * | ||
| * @param \Netgen\Bundle\InformationCollectionBundle\Form\FieldTypeHandlerInterface|callable $handler |
There was a problem hiding this comment.
I think we can remove callable, this was initially implemented for quite old SF version.
pspanja
reviewed
Mar 20, 2024
| * | ||
| * @param \Netgen\Bundle\InformationCollectionBundle\Form\FieldTypeHandlerInterface|callable $handler | ||
| */ | ||
| public function register(string $identifier, $handler): void |
There was a problem hiding this comment.
Typehit FieldTypeHandlerInterface.
pspanja
reviewed
Mar 20, 2024
| } | ||
| if (!$this->map[$identifier] instanceof FieldTypeHandlerInterface && !$this->map[$identifier] instanceof \Netgen\Bundle\IbexaFormsBundle\Form\FieldTypeHandlerInterface) { | ||
|
|
||
| if (!is_callable($this->map[$identifier])) { |
…FieldTypeHandlerRegistry.php
…dTypeHandlerInterface
iherak
changed the title
CED-2116 Collection deletion bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented editing the info collection.