Revert "Don't update resource on webhook notifications if not needed"

This reverts commit a090559.
netgen · Oct 24, 2023 · ec3356e · ec3356e
1 parent a090559
commit ec3356e
Showing 1 changed file with 3 additions and 18 deletions.
diff --git a/bundle/Controller/Callback/Cloudinary/Notify.php b/bundle/Controller/Callback/Cloudinary/Notify.php
@@ -257,26 +257,19 @@ private function handleTagsChanged(array $requestContent): void
                 continue;
             }
 
-            $changed = false;
-
             foreach ($resourceData['added'] ?? [] as $tag) {
                 $resource->addTag($tag);
-                $changed = true;
             }
 
             foreach ($resourceData['removed'] ?? [] as $tag) {
                 $resource->removeTag($tag);
-                $changed = true;
             }
 
             foreach ($resourceData['updated'] ?? [] as $tag) {
                 $resource->addTag($tag);
-                $changed = true;
             }
 
-            if ($changed === true) {
-                $this->provider->store($resource);
-            }
+            $this->provider->store($resource);
         }
     }
 
@@ -312,10 +305,7 @@ private function handleContextChanged(array $requestContent): void
                 continue;
             }
 
-            $changed = false;
-
             foreach ($resourceData['added'] ?? [] as $value) {
-                $changed = true;
                 switch ($value['name']) {
                     case 'alt':
                         $resource->setAltText($value['value']);
@@ -335,7 +325,6 @@ private function handleContextChanged(array $requestContent): void
             }
 
             foreach ($resourceData['removed'] ?? [] as $value) {
-                $changed = true;
                 switch ($value['name']) {
                     case 'alt':
                         $resource->setAltText(null);
@@ -355,15 +344,13 @@ private function handleContextChanged(array $requestContent): void
             }
 
             foreach ($resourceData['updated'] ?? [] as $value) {
-                $changed = true;
                 switch ($value['name']) {
                     case 'alt':
                         $resource->setAltText($value['value']);
                         break;
 
                     case 'caption':
-                        $resource->setCaption($value['value'])
-                        $changed = true;
+                        $resource->setCaption($value['value']);
                         break;
 
                     case 'original_filename':
@@ -375,9 +362,7 @@ private function handleContextChanged(array $requestContent): void
                 }
             }
 
-            if ($changed === true) {
-                $this->provider->store($resource);
-            }
+            $this->provider->store($resource);
         }
     }