Nggw 94 tabs eol #10
Open
Nggw 94 tabs eol #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This only includes php files - I think we should make sure to handle at least scss and js files as well? Personally, I would also like to see a hook which requires empty last line as well. |
|
And Twig files too. But in general, every file committed should be checked, except |
emodric
reviewed
Mar 6, 2023
src/Action/CheckForSpacesInEOL.php
Outdated
| use function array_diff; | ||
| use function implode; | ||
|
|
||
| final class CheckForSpacesInEOL extends Action |
There was a problem hiding this comment.
This should be named e.g. CheckForWhiteSpaceAtEOL, since it doesn't only remove spaces but all whitespace.
emodric
reviewed
Mar 6, 2023
src/Action/CheckForSpacesInEOL.php
Outdated
| } | ||
| } | ||
|
|
||
| private function getChangedFiles(Config\Action $action, Repository $repository): array |
There was a problem hiding this comment.
Can we move this duplicated method to a base Action class?
There was a problem hiding this comment.
This method is moved to the Action class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GIT hook for checking tabs vs spaces and EOL