-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netgen ibexa scheduled visibility #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pspanja
reviewed
Jun 24, 2024
pspanja
reviewed
Jun 24, 2024
pspanja
reviewed
Jun 24, 2024
pspanja
reviewed
Jun 24, 2024
pspanja
reviewed
Jun 24, 2024
pspanja
reviewed
Jun 24, 2024
pspanja
reviewed
Jun 24, 2024
pspanja
reviewed
Jun 26, 2024
pspanja
reviewed
Jun 26, 2024
@petarjakopec with the remaining remarks resolved, I'm pretty much out of ideas what to improve here. I'll test it on a bigger repo to see how performant it is. You can check if there is anything you would still want to improve from your side. And also update the docs, I didn't pay much attention to it so far. |
pspanja
reviewed
Jun 26, 2024
pspanja
reviewed
Jun 26, 2024
pspanja
reviewed
Jun 26, 2024
pspanja
reviewed
Jun 26, 2024
pspanja
reviewed
Jun 26, 2024
pspanja
reviewed
Jun 26, 2024
emodric
reviewed
Jun 26, 2024
emodric
reviewed
Jun 26, 2024
emodric
reviewed
Jun 26, 2024
emodric
reviewed
Jun 26, 2024
pspanja
reviewed
Jun 26, 2024
pspanja
reviewed
Jun 26, 2024
pspanja
reviewed
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing instance: https://media-site-scheduled-visibility.dev9.netgen.biz/
Everything except docs and integration tests is here(will update it), for testing:
I added all parameters to dev config file, by default they are not necessary and mechanism is disabled.
For content to be applicable for this mechanism, it needs to have two fields with identifiers publish_from and publish_to that are either ezdate or ezdatetime. I created one new content type scheduled_visibility for testing. Here is example of its content:
https://media-site-scheduled-visibility.dev9.netgen.biz/adminui/view/content/780/full/1/555.
Parameters example(from dev instance):
parameters:
netgen_ibexa_scheduled_visibility.enabled: true
netgen_ibexa_scheduled_visibility.strategy: 'location'
netgen_ibexa_scheduled_visibility.content_types.all: true
netgen_ibexa_scheduled_visibility.content_types.allowed: []
netgen_ibexa_scheduled_visibility.sections.hidden.section_id: 4
netgen_ibexa_scheduled_visibility.sections.visible.section_id: 1
netgen_ibexa_scheduled_visibility.object_states.object_state_group_id: 2
netgen_ibexa_scheduled_visibility.object_states.hidden.object_state_id: 3
netgen_ibexa_scheduled_visibility.object_states.visible.object_state_id: 1