Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netgen ibexa scheduled visibility #1

Merged
merged 103 commits into from
Jun 26, 2024
Merged

Conversation

petarjakopec
Copy link
Contributor

testing instance: https://media-site-scheduled-visibility.dev9.netgen.biz/
Everything except docs and integration tests is here(will update it), for testing:
I added all parameters to dev config file, by default they are not necessary and mechanism is disabled.
For content to be applicable for this mechanism, it needs to have two fields with identifiers publish_from and publish_to that are either ezdate or ezdatetime. I created one new content type scheduled_visibility for testing. Here is example of its content:
https://media-site-scheduled-visibility.dev9.netgen.biz/adminui/view/content/780/full/1/555.
Parameters example(from dev instance):
parameters:
netgen_ibexa_scheduled_visibility.enabled: true
netgen_ibexa_scheduled_visibility.strategy: 'location'
netgen_ibexa_scheduled_visibility.content_types.all: true
netgen_ibexa_scheduled_visibility.content_types.allowed: []
netgen_ibexa_scheduled_visibility.sections.hidden.section_id: 4
netgen_ibexa_scheduled_visibility.sections.visible.section_id: 1
netgen_ibexa_scheduled_visibility.object_states.object_state_group_id: 2
netgen_ibexa_scheduled_visibility.object_states.hidden.object_state_id: 3
netgen_ibexa_scheduled_visibility.object_states.visible.object_state_id: 1

@petarjakopec petarjakopec requested a review from pspanja June 21, 2024 08:57
@pspanja
Copy link
Member

pspanja commented Jun 26, 2024

@petarjakopec with the remaining remarks resolved, I'm pretty much out of ideas what to improve here. I'll test it on a bigger repo to see how performant it is. You can check if there is anything you would still want to improve from your side. And also update the docs, I didn't pay much attention to it so far.

@petarjakopec petarjakopec merged commit 70c3465 into master Jun 26, 2024
2 checks passed
@petarjakopec petarjakopec deleted the NGSTACK-842-dev-branch branch June 26, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants