Ngstack 833 cookie consent cookie policy improvements new #210
Conversation
| .ng-cc-cookie-policy-text { | ||
| position: absolute; | ||
| inset: 0; | ||
| z-index: 10000000; |
There was a problem hiding this comment.
100000 was not enough? :D
please add a proper value based on the bootstrap z-index states:
https://getbootstrap.com/docs/5.2/layout/z-index/
| z-index: 10000000; | ||
| transition: transform .3s ease; | ||
| transform: translateX(100%); | ||
| background: #fff; |
| <div class="ng-cc-modal"> | ||
| {% endif %} | ||
|
|
||
| {# cookie policy addition #} |
| @@ -127,6 +127,37 @@ | |||
| transform: translate(0, -50%); | |||
| } | |||
| } | |||
| &.btn-icon-chevron-left { | |||
There was a problem hiding this comment.
I understand what we have here but I would suggest separating concerns regarding buttons with icons in general and this particular example:
&[class*="btn-icon-"] {
// general rules for any button that has icon in it, like gap, &after rules, aligning etc
}
&.btn-icon-chevron-left {
&:after {
@extend %icon-chevron-left; // only the particular icon rendering
}
}
that way we can easily add new icons in buttons and coloring/styles are not involved only with class btn-icon-chevron-left
| @@ -0,0 +1,3 @@ | |||
| ngsite_view_payload: | |||
There was a problem hiding this comment.
Can you explain a bit why this route is used for?
In any case, this should not be located in media-site, but in netgen/site-bundle.
| @@ -7,6 +7,7 @@ ngsite.layout.powered_by: "Unterstützt durch" | |||
| ngsite.layout.cookie_settings: "Cookie Einstellungen" | |||
| ngsite.layout.cookie_settings.accepted: "Akzeptiert" | |||
| ngsite.layout.cookie_settings.not_accepted: "Nicht akzeptiert" | |||
| ngsite.layout.cookie_settings.go_back: "Go back" | |||
There was a problem hiding this comment.
Please add german label "Zurück"
| @@ -38,6 +39,11 @@ const componentConfiguration = [ | |||
| optionalListToggle: '.optional-list-toggle', | |||
| rotateArrowClass: 'rotate-arrow', | |||
| shownClass: 'shown', | |||
| cookieModal: '.ng-cc-modal', | |||
| cookiePolicyShow: '.ng-cc-js-link-cookie-policy a', | |||
There was a problem hiding this comment.
Is it possible to handle this to put the .ng-cc-js-link-cookie-policy class on link itself and not on wrapper and use the link as this value?
cookiePolicyShow: '.ng-cc-js-link-cookie-policy', // where html is text
There was a problem hiding this comment.
Also, a small nitpicker: can this key not be cookiePolicyShow but cookiePolicyShowTrigger?
No description provided.