IOTA-677 add method to send mail to users in bcc #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emodric
reviewed
Feb 15, 2024
| * @param array<string, mixed> $parameters | ||
| * @param string|string[]|null $sender | ||
| */ | ||
| public function sendGroupMail(array|string $bcc, string $subject, string $template, array $parameters = [], array|string|null $sender = null): void |
There was a problem hiding this comment.
What I would do here is not add a sendGroupMail that only sends to bcc, but add two new parameters at the end of sendMail method ccReceivers and bccReceivers which can then be used in conjuction with regular receivers.
It's a pretty common usecase to have a regular receiver and then a list of ccs and bccs.
This way, we would not have to hardcode that the sender is also a receiver, which is fine in itself, but not always.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.