Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onDepedencyChange #50

Merged
merged 9 commits into from
Mar 26, 2024
Merged

Add onDepedencyChange #50

merged 9 commits into from
Mar 26, 2024

Conversation

petrnymsa
Copy link
Member

@petrnymsa petrnymsa commented Mar 24, 2024

Wait for #49 merge

Fixes #42
Fixes #43
Fixes #51

@petrnymsa petrnymsa requested a review from tenhobi March 24, 2024 12:44
Copy link

github-actions bot commented Mar 24, 2024

DCM report

✅ no issues found!

Full report: https://github.com/netglade/glade_forms/runs/23109060740

@petrnymsa petrnymsa added this to the 2.0.0 milestone Mar 24, 2024
tenhobi
tenhobi previously approved these changes Mar 25, 2024
@petrnymsa petrnymsa dismissed tenhobi’s stale review March 25, 2024 12:16

The merge-base changed after approval.

@petrnymsa petrnymsa force-pushed the feat/42-ondeps-change branch from bc2ab68 to 71deb32 Compare March 25, 2024 12:16
@petrnymsa petrnymsa requested a review from tenhobi March 25, 2024 15:22
@petrnymsa petrnymsa requested a review from tenhobi March 26, 2024 14:58
@petrnymsa petrnymsa merged commit a9e6ae1 into main Mar 26, 2024
2 checks passed
@petrnymsa petrnymsa deleted the feat/42-ondeps-change branch March 26, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Extra as unuseful feature Remove dependencies from onChange callback Add onDependenciesChanged
2 participants