Merge pull request #6 from netglade/fix/tracking-id-nullability

Fix nullability of tracking id
netglade · Jul 19, 2024 · 8d77544 · 8d77544
2 parents 2bff688 + b46ffae
commit 8d77544
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 1.2.1
+- Fix nullability of trackingId in error handler
+
 ## 1.2.0
 - Use `trackable` package
 - UnexpectedError is now implementing GeneralTrackableError.

diff --git a/example/lib/main.dart b/example/lib/main.dart
@@ -124,7 +124,7 @@ class CounterBloc extends SafeBloc<CounterEvent, CounterState> {
   CounterState Function(UnexpectedError error) get errorState => CounterBlocError.new;
 
   @override
-  Future<void> onUnexpectedError(Object? error, StackTrace stackTrace, String? trackingId) async {
+  Future<void> onUnexpectedError(Object? error, StackTrace stackTrace, String trackingId) async {
     if (kDebugMode) {
       print('Exception: $error, $stackTrace');
     }

diff --git a/lib/src/safe_bloc_base.dart b/lib/src/safe_bloc_base.dart
@@ -15,7 +15,7 @@ abstract class SafeBlocBase<STATE, EFFECT> extends BlocBase<STATE>
 
   /// A method that is called each time the exception in the inherited Bloc or Cubit is thrown.
   @protected
-  Future<void> onUnexpectedError(Object? error, StackTrace stackTrace, String? trackingId) {
+  Future<void> onUnexpectedError(Object? error, StackTrace stackTrace, String trackingId) {
     return Future.value();
   }
 }
@@ -34,9 +34,9 @@ typedef SyncCallback = void Function(String trackingId);
 
 typedef OnIgnoreError = Future<void> Function(Object? error, StackTrace stackTrace);
 
-typedef OnError = Future<void> Function(Object? error, StackTrace stackTrace, String? trackingId);
+typedef OnError = Future<void> Function(Object? error, StackTrace stackTrace, String trackingId);
 
-typedef OnErrorSync = void Function(Object? error, StackTrace stackTrace, String? trackingId);
+typedef OnErrorSync = void Function(Object? error, StackTrace stackTrace, String trackingId);
 
 typedef ErrorMapper<STATE> = STATE? Function(Object error);
 

diff --git a/lib/src/safe_bloc_with_presentation.dart b/lib/src/safe_bloc_with_presentation.dart
@@ -78,5 +78,5 @@ abstract class SafeBlocWithPresentation<EVENT, STATE, EFFECT> extends Bloc<EVENT
   }
 
   @override
-  Future<void> onUnexpectedError(Object? error, StackTrace stackTrace, String? trackingId) => Future.value();
+  Future<void> onUnexpectedError(Object? error, StackTrace stackTrace, String trackingId) => Future.value();
 }
diff --git a/lib/src/safe_cubit_with_presentation.dart b/lib/src/safe_cubit_with_presentation.dart
@@ -62,5 +62,5 @@ abstract class SafeCubitWithPresentation<STATE, EFFECT> extends Cubit<STATE>
       );
 
   @override
-  Future<void> onUnexpectedError(Object? error, StackTrace stackTrace, String? trackingId) => Future.value();
+  Future<void> onUnexpectedError(Object? error, StackTrace stackTrace, String trackingId) => Future.value();
 }
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: safe_bloc
 description: An extension to bloc state management library that manages unexpected exceptions.
-version: 1.2.0
+version: 1.2.1
 repository: https://github.com/netglade/safe_bloc
 issue_tracker: https://github.com/netglade/safe_bloc/issues
 screenshots: