refactor: remove unused args in calls to getBuildSettings
#7182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndhoule
requested changes
Apr 9, 2025
src/utils/init/config-github.ts
Outdated
|
|
||
| const githubToken: Token = globalConfig.get(`users.${userId}.auth.github`) | ||
|
|
||
| if (githubToken && githubToken.user && githubToken.token) { | ||
| if (githubToken.user && githubToken.token) { |
There was a problem hiding this comment.
Is this right? Where do we validate that githubToken is not undefined?
There was a problem hiding this comment.
Bleh, good catch. What happened here is eslint --fix changed this automatically due to the incorrect Token type.
The GlobalConfigStore refactor was great but we should fix that any. Dunno what the best approach will be there though... maybe use zod?
There was a problem hiding this comment.
Yep, we should parse the config file when we load it (the challenge is being very careful about the shape of the global config file).
ndhoule
approved these changes
Apr 14, 2025
serhalp
force-pushed
the
refactor/remove-unused-args
branch
from
5b3d785 to
7d47191
Compare
serhalp
force-pushed
the
refactor/remove-unused-args
branch
from
7d47191 to
bb24853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The types fixes in #7130 identified a number of issues. This fixes one of those — just some unused args passed to a function.