refactor: type deploy command input args #7194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
approved these changes
Apr 11, 2025
This prevents us from loading the `deploy` command's full dependency tree when we know we can't service the user's request.
ndhoule
force-pushed
the
nathanhoule/cpla-2545-change-ntl-deploy-to-build-by-default--refactor-types
branch
from
9dc32fe to
24376c5
Compare
ndhoule
deleted the
nathanhoule/cpla-2545-change-ntl-deploy-to-build-by-default--refactor-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds basic TypeScript types to the
deploycommand's input arguments (i.e. the command-line flags that a user passes to thenetlify deploycommand).I also lifted some input argument validation out of the
deploycommand's business logic into thecreateDeployCommandfunction as a minor optimization so we don't pull in the full deploy dependency tree when we know we can't service a user's request.