-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: external state storage for netflow/ipfix template & sampling rate data #289
Open
iqbalaydrus
wants to merge
27
commits into
netsampler:main
Choose a base branch
from
bangunindo:iqbal/state
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add default rendering for MplsIp is enough
…dtime larger than uptime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired from vflow discovery to sync its templates between instances. But instead of using multicast ip, it's using redis kv & pubsub because it's more friendly in a cloud environment. I created this for two purposes:
But also worth noting, the in memory engine benchmark is worse than the current implementation, 72.90ns vs 28.12ns per operation, or 17 vs 35 Mops/s, or 109 Gbps vs 280 Gbps of flows (assuming 1000 bytes size per packet). It's allocating more for extra metadata when marshalling. But it's still on the tens of millionth operation per second, I think the bottleneck will still be somewhere else.