Skip to content

Commit

Permalink
FQCN changes 2
Browse files Browse the repository at this point in the history
  • Loading branch information
shivashankar-vaddepally committed Dec 10, 2024
1 parent 192c4f6 commit 9b92679
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
4 changes: 2 additions & 2 deletions examples/ssh_connections/multiple_plays.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
ansible.builtin.debug:
msg: "{{ echo_result }}"

- name: Ansible ssh playbook
- name: Ansible ssh playbook
hosts: demo_netscalers
gather_facts: false
tasks:
Expand All @@ -27,7 +27,7 @@
nsip: "{{ ansible_host }}"
nitro_user: "{{ remote_user }}"
nitro_pass: "{{ nitro_pass }}"
validate_certs: no
validate_certs: false

name: test-server-1
ipaddress: 192.168.2.2
3 changes: 2 additions & 1 deletion examples/ssh_connections/nscli_command.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
- name: Run nscli command
hosts: demo_netscalers
remote_user: nsroot
Expand All @@ -12,7 +13,7 @@

tasks:
- name: Run nscli command

Check failure on line 15 in examples/ssh_connections/nscli_command.yaml

View workflow job for this annotation

GitHub Actions / ansible-lint

command-instead-of-shell

Use shell only when shell functionality is required.

Check failure on line 15 in examples/ssh_connections/nscli_command.yaml

View workflow job for this annotation

GitHub Actions / ansible-lint

no-changed-when

Commands should not change things if nothing needs doing.
ansible.builtin.shell: "nscli -s -U :nsroot:{{nitro_pass}} {{ nscli_command }}"
ansible.builtin.shell: "nscli -s -U :nsroot:{{ nitro_pass }} {{ nscli_command }}"
no_log: true
register: nscli_output

Expand Down
5 changes: 3 additions & 2 deletions examples/ssh_connections/show_tech_support.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
#
# Execute like: ansible-playbook show_tech_support.yml -i hosts
#
- name: Ansible ssh playbook
---
- name: Ansible ssh playbook
hosts: demo_netscalers
remote_user: nsroot
connection: netscaler.adc.ssh_netscaler_adc
Expand All @@ -12,7 +13,7 @@

tasks:
- name: Generate technical support bundle
ansible.builtin.shell: "nscli -s -U :nsroot:{{nitro_pass}} show techsupport"
ansible.builtin.shell: "nscli -s -U :nsroot:{{ nitro_pass }} show techsupport"
register: sts_output
no_log: true

Expand Down
2 changes: 1 addition & 1 deletion meta/runtime.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
# Collections must specify a minimum required ansible version to upload
# to galaxy
requires_ansible: '>=2.14.0'
requires_ansible: '>=2.15.0'
# Content that Ansible needs to load from another location or that has
# been deprecated/removed
# plugin_routing:
Expand Down

0 comments on commit 9b92679

Please sign in to comment.