Dumper: disabled HASH disables "see above/see below"

nette · Apr 28, 2022 · d9c2e36 · d9c2e36
1 parent d6261b5
commit d9c2e36
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/src/Tracy/Dumper/Renderer.php b/src/Tracy/Dumper/Renderer.php
@@ -283,9 +283,10 @@ private function renderArray($array, int $depth): string
 					$ref = new Value(Value::TYPE_REF, $array->id);
 					$this->copySnapshot($ref);
 					return '<span class="tracy-toggle tracy-collapsed" data-tracy-dump=\'' . json_encode($ref) . "'>" . $out . '</span>';
-				}
 
-				return $out . (isset($this->above[$array->id]) ? ' <i>see above</i>' : ' <i>see below</i>');
+				} elseif ($this->hash) {
+					return $out . (isset($this->above[$array->id]) ? ' <i>see above</i>' : ' <i>see below</i>');
+				}
 			}
 		}
 
@@ -364,9 +365,10 @@ private function renderObject(Value $object, int $depth): string
 				$ref = new Value(Value::TYPE_REF, $object->id);
 				$this->copySnapshot($ref);
 				return '<span class="tracy-toggle tracy-collapsed" data-tracy-dump=\'' . json_encode($ref) . "'>" . $out . '</span>';
-			}
 
-			return $out . (isset($this->above[$object->id]) ? ' <i>see above</i>' : ' <i>see below</i>');
+			} elseif ($this->hash) {
+				return $out . (isset($this->above[$object->id]) ? ' <i>see above</i>' : ' <i>see below</i>');
+			}
 		}
 
 		$collapsed = $object->collapsed ?? ($depth

diff --git a/tests/Tracy/Dumper.toText().nohash.phpt b/tests/Tracy/Dumper.toText().nohash.phpt
@@ -37,3 +37,16 @@ stdClass
    z: stdClass RECURSION
 XX
 , Dumper::toText($arr, [Dumper::HASH => false]));
+
+
+$obj = (object) ['a' => 1];
+Assert::match(<<<'XX'
+array (3)
+   0 => stdClass
+   |  a: 1
+   1 => stdClass
+   |  a: 1
+   2 => stdClass
+   |  a: 1
+XX
+, Dumper::toText([$obj, $obj, $obj], [Dumper::HASH => false]));