Skip to content

emacstbl.pl: Add proper header and footer #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

8dcc
Copy link

@8dcc 8dcc commented Mar 20, 2025

Changes the header and footer of the nasmtok.el file generated by emacstbl.pl. This change is needed for closing skeeto/nasm-mode#14, currently being tested in a require-nasmtok (skeeto/nasm-mode@826f881) branch.

For more information about the library header convention in Elisp, see: https://www.gnu.org/software/emacs/manual/html_node/elisp/Library-Headers.html

@8dcc
Copy link
Author

8dcc commented Mar 20, 2025

I also noticed that some preprocessor tokens such as struc, endstruc, istruc, iend and at are not included in the generated nasmtok.el file.

By looking at the following lines, I can see that some other tokens from the nasm-pp-directives list might be missing as well, such as align and alignb: https://github.com/skeeto/nasm-mode/blob/4e670f6dededab858251670aa5459c950f78d867/nasm-mode.el#L528-L534

Please, review this and add them if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant