Delete tap interfaces on startup #545
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glazychev-art
force-pushed
the
tap_restore
branch
4 times, most recently
from
87a5436
to
71607aa
Compare
glazychev-art
force-pushed
the
tap_restore
branch
from
71607aa
to
6e37e82
Compare
Signed-off-by: Artem Glazychev <[email protected]>
glazychev-art
force-pushed
the
tap_restore
branch
from
6e37e82
to
193d7bd
Compare
glazychev-art
changed the title
|
@denis-tingaikin @edwarnicke |
edwarnicke
reviewed
Apr 6, 2022
|
|
||
| dumpOption := &dumptool.DumpOption{ | ||
| Ctx: ctx, | ||
| PodName: opts.name, |
There was a problem hiding this comment.
Is this actually just a prefix for the tag? If so, could we name it something like TagPrefix rather than PodName? With the advent of networkservicemesh/cmd-nse-simple-vl3-docker#1 we will be using SDK components in non-K8s environments.
There was a problem hiding this comment.
Yes. Thank you.
I've simplified a little this PR - now TagPrefix is not passed to the mechanism chain element as parameter.
Instead, there is only DumpNSM func as option, that applies OnDump func of the mechainsm
Signed-off-by: Artem Glazychev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete tap interfaces on startup
Now each mechanism is responsible for dumping and deleting its interfaces on startup by tag.
In this PR
kernelmechanism callsonDumpIssue: #512
Signed-off-by: Artem Glazychev [email protected]