Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pyyaml to 6.0.2 in poetry.lock #284

Merged
merged 2 commits into from
Dec 10, 2024
Merged

update pyyaml to 6.0.2 in poetry.lock #284

merged 2 commits into from
Dec 10, 2024

Conversation

gsnider2195
Copy link
Contributor

The pyyaml version in the lock file fails to install due to python-poetry/poetry#8287 / yaml/pyyaml#601

glennmatthews
glennmatthews previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Should we update the dependency in pyproject.toml?

@gsnider2195
Copy link
Contributor Author

Seems reasonable to me. Should we update the dependency in pyproject.toml?

I think making 6.0.1 or 6.0.2 the minimum would make sense

@gsnider2195 gsnider2195 merged commit 85bfac4 into develop Dec 10, 2024
17 checks passed
@gsnider2195 gsnider2195 deleted the u/gas-fix-poetry-install-pyyaml branch December 10, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

@Kircheneer Kircheneer Awaiting requested review from Kircheneer Kircheneer is a code owner

@chadell chadell Awaiting requested review from chadell chadell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsnider2195 @glennmatthews