Feat/delete book #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # backend/src/main/java/com/github/esgoet/backend/controllers/BookController.java # backend/src/main/java/com/github/esgoet/backend/services/BookService.java # backend/src/test/java/com/github/esgoet/backend/controllers/BookControllerIntegrationTest.java # backend/src/test/java/com/github/esgoet/backend/services/BookServiceUnitTest.java # frontend/src/pages/BookGalleryPage/components/bookCard/BookCard.tsx
esgoet
reviewed
Aug 15, 2024
| bookRepository.save(new Book("1", "Simon", "HowToDeleteBooksFast")); | ||
|
|
||
| mockMvc.perform(MockMvcRequestBuilders.delete("/api/books/1")) | ||
| .andExpect(status().isOk()); |
There was a problem hiding this comment.
delete Integration test should include performing a getAll and expecting an empty list?
mockMvc.perform(MockMvcRequestBuilders.get("/api/books"))
.andExpect(status().isOk())
.andExpect(content().json("""
[]
"""));
| @@ -19,13 +19,19 @@ export default function BookDetailsPage() { | |||
| fetchBook(); | |||
| },[]) | |||
|
|
|||
| const deleteBook = (id: string) => { | |||
| axios.delete("/api/books/" + id) | |||
There was a problem hiding this comment.
needs reload of data and going back to books page? can useNavigate and might be good to do have the actual deletion method in App.tsx and just pass it to BookDetailsPage, so we can call fetchData easily in the delete method
also should have catching error
In App.tsx:
function deleteBook(string :id) {
axios.delete("/api/books/" + id)
.then((response) => response.status === 200 && fetchData())
.catch((error)=>console.log(error.message))
}
in BookDetailsPage.tsx:
Suggested change
| axios.delete("/api/books/" + id) | |
| deleteBook(id); | |
| navigate("/books"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a DELETE endpoint in the backend to delete books by id.
Added a "Delete" Button to the Details page.