Merge pull request #20 from neuefische/ISSUE-11

ISSUE-11: Create a POST create new actor endpoint and cover it with tests.
neuefische · Oct 16, 2024 · 7c2aef3 · 7c2aef3
2 parents 63937ed + 5fdb40e
commit 7c2aef3
Show file tree

Hide file tree

Showing 6 changed files with 66 additions and 11 deletions.
diff --git a/backend/src/main/java/com/example/backend/dto/CreateActorRequest.java b/backend/src/main/java/com/example/backend/dto/CreateActorRequest.java
@@ -1,10 +1,11 @@
 package com.example.backend.dto;
 
 import com.example.backend.model.Actor;
+import lombok.NonNull;
 
 public record CreateActorRequest(
-        String name
-) {
+        @NonNull String name
+        ) {
     public Actor toActor() {
         return Actor.builder().name(name).build();
     }

diff --git a/backend/src/main/java/com/example/backend/model/Actor.java b/backend/src/main/java/com/example/backend/model/Actor.java
@@ -17,8 +17,9 @@ public class Actor {
     @GeneratedValue
     private Long id;
 
-    @ManyToMany(cascade = {CascadeType.DETACH, CascadeType.MERGE, CascadeType.PERSIST, CascadeType.REFRESH})
+    @ManyToMany(cascade = {CascadeType.DETACH, CascadeType.MERGE, CascadeType.PERSIST, CascadeType.REFRESH}, fetch = FetchType.EAGER)
     private Set<Movie> movies;
 
+    @Column(nullable = false)
     private String name;
 }
diff --git a/backend/src/main/java/com/example/backend/model/Director.java b/backend/src/main/java/com/example/backend/model/Director.java
@@ -17,7 +17,7 @@ public class Director {
     @GeneratedValue
     private Long id;
 
-    @ManyToMany(cascade = {CascadeType.DETACH, CascadeType.MERGE, CascadeType.PERSIST, CascadeType.REFRESH})
+    @ManyToMany(cascade = {CascadeType.DETACH, CascadeType.MERGE, CascadeType.PERSIST, CascadeType.REFRESH}, fetch = FetchType.EAGER)
     private Set<Movie> movies;
 
     private String name;

diff --git a/backend/src/main/java/com/example/backend/model/Movie.java b/backend/src/main/java/com/example/backend/model/Movie.java
@@ -12,11 +12,11 @@ public class Movie {
 
     private Double rating;
 
-    @ManyToMany(cascade = {CascadeType.DETACH, CascadeType.MERGE, CascadeType.PERSIST, CascadeType.REFRESH})
-    Set<Actor> actors;
+    @ManyToMany(cascade = {CascadeType.DETACH, CascadeType.MERGE, CascadeType.PERSIST, CascadeType.REFRESH}, fetch = FetchType.EAGER)
+    private Set<Actor> actors;
 
-    @ManyToMany(cascade = {CascadeType.DETACH, CascadeType.MERGE, CascadeType.PERSIST, CascadeType.REFRESH})
-    Set<Director> directors;
+    @ManyToMany(cascade = {CascadeType.DETACH, CascadeType.MERGE, CascadeType.PERSIST, CascadeType.REFRESH}, fetch = FetchType.EAGER)
+    private Set<Director> directors;
 
     private String name;
 }
diff --git a/backend/src/main/java/com/example/backend/service/ActorService.java b/backend/src/main/java/com/example/backend/service/ActorService.java
@@ -1,6 +1,5 @@
 package com.example.backend.service;
 
-import com.example.backend.dto.CreateActorRequest;
 import com.example.backend.model.Actor;
 import com.example.backend.model.ActorRepository;
 import lombok.AllArgsConstructor;

diff --git a/backend/src/test/java/com/example/backend/controller/ActorControllerTest.java b/backend/src/test/java/com/example/backend/controller/ActorControllerTest.java
@@ -6,13 +6,14 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
 import org.springframework.boot.test.context.SpringBootTest;
-import org.springframework.data.domain.Example;
 import org.springframework.http.MediaType;
 import org.springframework.test.annotation.DirtiesContext;
 import org.springframework.test.web.servlet.MockMvc;
 import org.springframework.test.web.servlet.request.MockMvcRequestBuilders;
+import org.springframework.test.web.servlet.result.MockMvcResultMatchers;
 
 import java.util.List;
+import java.util.Set;
 
 import static org.junit.jupiter.api.Assertions.*;
 
@@ -27,7 +28,60 @@ class ActorControllerTest {
 
     @Test
     @DirtiesContext
-    void save() throws Exception {
+    void saveTest_correct() throws Exception {
+        mvc.perform(MockMvcRequestBuilders.post("/api/actor")
+                .contentType(MediaType.APPLICATION_JSON)
+                .content(
+                        """
+                                 {
+                                      "name": "John Doe"
+                                 }
+                                """
+                ))
+                .andExpect(MockMvcResultMatchers.status().isOk());
+
+        List<Actor> actual = repository.findAll();
+        List<Actor> expected = List.of(Actor.builder().id(1L).movies(Set.of()).name("John Doe").build());
+        assertEquals(expected, actual);
+    }
+
+    @Test
+    @DirtiesContext
+    void saveTest_correct_idIgnored() throws Exception {
+        mvc.perform(MockMvcRequestBuilders.post("/api/actor")
+                .contentType(MediaType.APPLICATION_JSON)
+                .content(
+                        """
+                                 {
+                                        "id": "2",
+                                        "name": "Jane Doe"
+                                 }
+                        """
+                ))
+                .andExpect(MockMvcResultMatchers.status().isOk());
+
+        List<Actor> actual = repository.findAll();
+        List<Actor> expected = List.of(Actor.builder().id(1L).movies(Set.of()).name("Jane Doe").build());
+        assertEquals(expected, actual);
+    }
+
+    @Test
+    @DirtiesContext
+    void saveTest_incorrectNoName() throws Exception {
+        mvc.perform(MockMvcRequestBuilders.post("/api/actor")
+                .contentType(MediaType.APPLICATION_JSON)
+                .content(
+                        """
+                                 {
+                                        "id": "2"
+                                 }
+                        """
+                ))
+                .andExpect(MockMvcResultMatchers.status().is4xxClientError());
+
+        List<Actor> actual = repository.findAll();
+        List<Actor> expected = List.of();
+        assertEquals(expected, actual);
     }
 
     @Test