Fix generator progress bar #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have once encountered this. Just use p.update(len - p.t) fix it 🤔 |
|
Yeah, that's basically what this PR does. You can see the diff here: https://github.com/neulab/prompt2model/compare/refactor_dataset_generator..fix_generator_progress_bar |
|
@neubig do you need to re-merge main into this branch? It says there are 1k lines added which seems wrong from the description of this PR. |
|
This builds of 335 and 336 so they should be reviewed first, but you can also look at the diff that I posted above too |
zhaochenyang20
changed the base branch from
main
to
use_cached_dataset_retriever
Co-authored-by: Vijay Viswanathan <[email protected]>
…_dataset_retriever
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The generator progress bar was broken, making it look like progress was faster than it actually was.
References
Blocked by