-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade insightface #447
base: main
Are you sure you want to change the base?
Upgrade insightface #447
Conversation
Can confirm, fix works :) |
Again getting the same error "RetinaFace.detect() got an unexpected keyword argument 'threshold'". Can you share your .ipynb file? !git clone https://github.com/woctezuma/SimSwap.git |
You should use the branch which incorporates the fix. !git clone https://github.com/woctezuma/SimSwap.git --branch upgrade-insightface --single-branch Otherwise you get the main branch, which is an exact copy of the official |
Ok thank you, It works like a charm. It is 9 commits behind, will you update it? |
147f560
to
63306e7
Compare
I can do that, but there is no much point: only the README and the notebook were modified in the 9 commits, so no Python code. Edit: Done this time, but the point of this branch is that the pull request could be merged in the official repository, not to maintain it whenever there is a new update in the official repository. 😛 |
63306e7
to
037c7f7
Compare
ok |
In the latest insightface version, delete line 65 of
TO
|
Yes, that is partially what I did:
If you only do that, then you cannot specify the detection threshold. For instance, the default value (0.5) is used instead of 0.6.
SimSwap/test_wholeimage_swapsingle.py Lines 55 to 56 in a5f6dea
NB:
based on the outputs found in Colab:
So the detection model is SCRFD. SimSwap/insightface_func/face_detect_crop_single.py Lines 41 to 43 in a5f6dea
SimSwap/insightface_func/face_detect_crop_single.py Lines 47 to 48 in a5f6dea
|
The following issue arises with
insightface==0.6.2
or below, including the recommended version (0.2.1).See:
This issue is fixed by upgrading to
insightface==0.7
or above, but the following issue arises.This pull request fixes this second issue, which allows to use the latest version of
insightface
(0.7.3).Fix: