Return missing permissions on 403 Forbidden #89
Conversation
atemate
force-pushed
the
ay/improve-403-tests
branch
from
f846635 to
e6b7740
Compare
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 11 11
Lines 876 876
Branches 76 76
=======================================
Hits 812 812
Misses 42 42
Partials 22 22
Continue to review full report at Codecov.
|
atemate
changed the title
Makefile
Outdated
| @@ -3,6 +3,10 @@ IMAGE_TAG ?= latest | |||
| ARTIFACTORY_TAG ?=$(shell echo "$(CIRCLE_TAG)" | awk -F/ '{print $$2}') | |||
| IMAGE ?= $(GKE_DOCKER_REGISTRY)/$(GKE_PROJECT_ID)/$(IMAGE_NAME) | |||
|
|
|||
| IMAGE_PLATFORM_API = $(GKE_DOCKER_REGISTRY)/$(GKE_PROJECT_ID)/platformapi:3e475aa6a0665e2a88ec854f59ec092a6472cb91 | |||
| IMAGE_PLATFORM_AUTH_API = $(GKE_DOCKER_REGISTRY)/$(GKE_PROJECT_ID)/platformauthapi:33318ecfd6ca5b0974f050f16b780d57e4a43e4f | |||
There was a problem hiding this comment.
note: we also updated platformauthapi's version
There was a problem hiding this comment.
what I don't like here is that this won't work locally as opposed to platform-api. we do not want to combine images names like this, I think, because we already know the resulting name anyhow. and when we decide to migrate to Artifacotry completely, we'll have to ditch this anyways.
There was a problem hiding this comment.
so, please, could we use an approach similar to platform-api here?
There was a problem hiding this comment.
not in this PR. Reverted back.
|
LGTM |
|
re-worked |
Closes #79