Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plot_trajectory in broadcasting example #414

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

willGraham01
Copy link
Contributor

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

#409

What does this PR do?

Uses the plot_trajectory function in our broadcasting example to reduce load and also show-off our features.

References

Closes #409

How has this PR been tested?

Example still works locally and after being built in the docs.

Is this a breaking change?

Does this PR require an update to the documentation?

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

This comment was marked as resolved.

Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willGraham01, I just have one comment to ged rid of some redundant lines. After that it's good to merge!

examples/broadcasting_your_own_methods.py Outdated Show resolved Hide resolved

This comment was marked as resolved.

@willGraham01 willGraham01 added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 0e1951d Feb 13, 2025
28 checks passed
@niksirbi niksirbi deleted the wgraham-409-use-trajectory-in-example branch February 13, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use plot_trajectory in broadcasting example
2 participants