Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in fhn and hopf OC #255

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Fix bug in fhn and hopf OC #255

merged 5 commits into from
Feb 13, 2024

Conversation

lenasal
Copy link
Collaborator

@lenasal lenasal commented Jan 5, 2024

network jacobian was not computed correctly for diffusive coupling in fhn and hopf model

@lenasal lenasal self-assigned this Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (762456a) 91.14% compared to head (cffa710) 91.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          65       65           
  Lines        5189     5189           
=======================================
  Hits         4729     4729           
  Misses        460      460           
Flag Coverage Δ
unittests 91.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenasal lenasal closed this Jan 19, 2024
@lenasal lenasal deleted the OCdev branch January 19, 2024 08:25
@lenasal lenasal restored the OCdev branch January 19, 2024 08:25
@lenasal lenasal reopened this Jan 19, 2024
@lenasal
Copy link
Collaborator Author

lenasal commented Jan 19, 2024

closing pull request was by accident, sorry!

@lenasal lenasal removed the request for review from caglorithm January 29, 2024 16:41
@lenasal lenasal changed the title Fix bug in fhn and hopf Fix bug in fhn and hopf OC Jan 31, 2024
@caglorithm caglorithm merged commit b797770 into neurolib-dev:master Feb 13, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants