Skip to content

Commit

Permalink
Report all gout errors; fix 116094 267599, 2014814 (#92)
Browse files Browse the repository at this point in the history
* gout: report errors
* 267599, 2014814: model dirs
* 116094: do not run so much to avoid gout diff
  • Loading branch information
olupton authored Jul 17, 2023
1 parent 5c00892 commit 3781c1b
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 6 deletions.
2 changes: 1 addition & 1 deletion modeldb/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ def diffreports2html(args=None):
assert "0" in diff_dict # summary info; not a real diff
print("FAILURE: stdout diffs in {}".format(set(diff_dict.keys()) - {"0"}))
code = 1
if len(gout_dict) > 1:
if len(gout_dict):
print("FAILURE: gout diffs in {}".format(set(gout_dict.keys())))
code = 1
total_failures = sum(
Expand Down
24 changes: 19 additions & 5 deletions modeldb/modeldb-run.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -851,11 +851,12 @@
- init()
- run()
- verify_graph_()
- run_experiment("fig1")
- tstop=1
- init()
- run_fig1bde()
- verify_graph_()
# At some point post-8.2.2 run_fig1bde stopped returning => gout diff
# - run_experiment("fig1")
# - tstop=1
# - init()
# - run_fig1bde()
# - verify_graph_()
116096:
run:
- tstop=1
Expand Down Expand Up @@ -1530,6 +1531,9 @@
comment: 'Seems to be missing files: parinit.hoc, .mod file for h_ca, ...?'
model_dir: mods
run: null
267599:
# There is also a subdirectory that seems to have older versions.
model_dir: "."
267691:
# output is two data files Vm_6_1.dat Vm_axon_6_1.dat, which should be compared...
hoc_stack_size: 2000 # default of 1000 is apparently not enough
Expand Down Expand Up @@ -1597,3 +1601,13 @@
- sed -i'.bak' -e 's/plt.show()/plt.show(block=False);plt.pause(1);plt.close();quit()/' clay_mohit.py
251881:
model_dir: mechanisms
2014814:
# Note there are many other models and HOC versions under this accession ID
model_dir: Models/1-Neuromuscular/Python
python: true
run:
- "import matplotlib"
- "matplotlib.use('agg')" # headless
- "with open('Models/1-Neuromuscular/Python/run.py') as ifile:"
- " exec(ifile.read())"
- "quit()"

0 comments on commit 3781c1b

Please sign in to comment.