Unified all mpi assert mechanisms #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkino
force-pushed
the
cornu/clean_mpispike
branch
from
b98f427 to
81a789b
Compare
|
✔️ 40e481a -> Azure artifacts URL |
Codecov Report
@@ Coverage Diff @@
## master #2465 +/- ##
=======================================
Coverage 61.53% 61.53%
=======================================
Files 625 625
Lines 119263 119227 -36
=======================================
- Hits 73384 73362 -22
+ Misses 45879 45865 -14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
nrnhines
approved these changes
Aug 16, 2023
|
✔️ 404f5d1 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ f272f9b -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
✔️ 52b122f -> Azure artifacts URL |
|
✔️ 7aa8abd -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alkino
force-pushed
the
cornu/clean_mpispike
branch
from
a0c0141 to
bc00684
Compare
Use a new nrn_mpi_assert everywhere.
alkino
force-pushed
the
cornu/clean_mpispike
branch
from
bc00684 to
88f0702
Compare
|
✔️ 88f0702 -> Azure artifacts URL |
|
✔️ fa06fcc -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ 427ad30 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
alexsavulescu
approved these changes
Sep 28, 2023
This comment has been minimized.
This comment has been minimized.
Internally we have some constants that mean: 1 - MPI_SUM 2 - MPI_MAX 3 - MPI_MIN
|
✔️ 7ad9347 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
nrnhines
reviewed
Sep 29, 2023
|
✔️ 7a41b6e -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ 8686690 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ ae02186 -> Azure artifacts URL |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a new nrn_mpi_assert everywhere.