Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constify OcMatrix #3148

Merged
merged 10 commits into from
Oct 30, 2024
Merged

Constify OcMatrix #3148

merged 10 commits into from
Oct 30, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Oct 29, 2024 •
edited
Loading

Minify usage of mep as it get a non stable pointer on the matrix itself.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ 75c6447 -> Azure artifacts URL

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.98246% with 65 lines in your changes missing coverage. Please review.

Project coverage is 67.17%. Comparing base (cd7ac7d) to head (46df5fe).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/rxd_extracellular.cpp 11.53% 23 Missing ⚠️
src/ivoc/ocmatrix.h 15.38% 22 Missing ⚠️
src/ivoc/ocmatrix.cpp 56.09% 18 Missing ⚠️
src/ivoc/matrix.cpp 85.71% 1 Missing ⚠️
src/nrnpython/rxd.cpp 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3148   +/-   ##
=======================================
  Coverage   67.17%   67.17%           
=======================================
  Files         573      573           
  Lines      111439   111436    -3     
=======================================
+ Hits        74856    74858    +2     
+ Misses      36583    36578    -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ 56601fa -> Azure artifacts URL

1uc
1uc approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, minor comments only.

src/ivoc/ocmatrix.h Outdated Show resolved Hide resolved
src/ivoc/ocmatrix.cpp Show resolved Hide resolved
@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
48 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
15.8% Duplication on New Code

See analysis details on SonarCloud

@azure-pipelines Azure Pipelines
Copy link

✔️ 46df5fe -> Azure artifacts URL

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #237153 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alkino alkino merged commit d52f6ae into master Oct 30, 2024
36 checks passed
@alkino alkino deleted the cornu/ocmatrix_better branch October 30, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1uc 1uc 1uc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alkino @bbpbuildbot @1uc